Fix HTTP connection leak when using feign.Response with chunked Transfer-Encoding#1346
Open
ban-xiu wants to merge 1 commit intospring-cloud:mainfrom
Open
Fix HTTP connection leak when using feign.Response with chunked Transfer-Encoding#1346ban-xiu wants to merge 1 commit intospring-cloud:mainfrom
ban-xiu wants to merge 1 commit intospring-cloud:mainfrom
Conversation
Signed-off-by: lanbinshen <lanbinshen@xiaomi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Close #1198. When a @FeignClient method declares feign.Response as its return type and the server responds with Transfer-Encoding: chunked, the underlying HTTP connection is never released back to the connection pool, causing a connection leak.
Root Cause
Feign-core's InvocationContext.proceed() has a special path for feign.Response return type — it bypasses the entire decoder chain and calls disconnectResponseBodyIfNeeded(). This method only buffers the response body when body.length() != null && body.length() <= 8192.
For chunked responses, body.length() returns null (content length is unknown), so the buffering is skipped and the raw Response with a live InputStream tied to the pooled HTTP connection is returned directly to the caller. If the caller does not explicitly close the Response, the connection is permanently leaked.
Fix
Register a default ResponseInterceptor bean in FeignClientsConfiguration that intercepts the response before it reaches feign-core's disconnectResponseBodyIfNeeded().
When the return type is feign.Response and the body has unknown length (chunked), the interceptor: