fix: preserve query string params for multipart requests in Gateway MVC#4162
Open
ar249 wants to merge 1 commit into
Open
fix: preserve query string params for multipart requests in Gateway MVC#4162ar249 wants to merge 1 commit into
ar249 wants to merge 1 commit into
Conversation
39b8355 to
9281eb9
Compare
Fixes spring-cloudgh-3220 Signed-off-by: Arindam Singh <96876969+ar249@users.noreply.github.com>
9281eb9 to
9f00e47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a multipart POST request with query string parameters was routed through Spring Cloud Gateway MVC, the query string parameters were silently dropped before reaching the downstream service.
Root cause
StandardMultipartHttpServletRequestmerges multipart body parts into the parameter map, overwriting query string parameters in the process.Solution
Updated the logic inside
getParameterMap()inGatewayMultipartHttpServletRequestto decode and return only the query string parameters for gateway requests usingMvcUtils.decodeQueryString(), ensuring the multipart body is not parsed and query string params are preserved as-is.Changes
GatewayMultipartHttpServletReques.getParameterMap()— fixed query string decoding logic inside the gateway request guard blockGatewayMvcMultipartResolverTest— new test class covering:nullquery string returns an empty mapinitializeMultipart()is never called, body fields do not appear in the parameter map)super.getParameterMap()Fixes gateway MVC - Multi-part + query string not working #3220