Refactor route-specific CORS to be route-bound instead of path-bound#4131
Open
qnnn wants to merge 2 commits intospring-cloud:mainfrom
Open
Refactor route-specific CORS to be route-bound instead of path-bound#4131qnnn wants to merge 2 commits intospring-cloud:mainfrom
qnnn wants to merge 2 commits intospring-cloud:mainfrom
Conversation
Move CORS configuration reading from CorsGatewayFilterApplicationListener (pre-populated at startup by path) to RoutePredicateHandlerMapping#getCorsConfiguration (read from route metadata during request). This allows independent CORS configurations for multiple routes sharing the same path predicate. Signed-off-by: qnnn <qiunan@cmbchina.com>
…EndpointRedisRefreshTest. Signed-off-by: qnnn <qiunan@cmbchina.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the route-specific CORS implementation by moving the logic from CorsGatewayFilterApplicationListener into RoutePredicateHandlerMapping#getCorsConfiguration.
Problem
The current implementation of route-specific CORS is not actually bound to the route, but to the path predicate. This approach:
Solution
Instead of pre-populating CORS configurations by path at startup, the new implementation reads CORS configuration directly from the matched route's metadata during request processing.