Support fractional replenishRate in RedisRateLimiter#4046
Open
abhijeet4725 wants to merge 3 commits intospring-cloud:mainfrom
Open
Support fractional replenishRate in RedisRateLimiter#4046abhijeet4725 wants to merge 3 commits intospring-cloud:mainfrom
abhijeet4725 wants to merge 3 commits intospring-cloud:mainfrom
Conversation
Signed-off-by: abhijeet4725 <abhijeetcs4725@gmail.com>
spencergibb
requested changes
Jan 25, 2026
Member
spencergibb
left a comment
There was a problem hiding this comment.
The build failed in redis rate limiter tests, so this has broken something
Signed-off-by: abhijeet4725 <abhijeetcs4725@gmail.com>
Signed-off-by: abhijeet4725 <abhijeetcs4725@gmail.com>
Contributor
Author
|
Thanks for the review! I’ve applied the requested change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
replenishRateinRedisRateLimiterand its innerConfigclass todoubleto allow fractional refill rates.@Min(1)to@DecimalMin(value="0.0", inclusive=false)to allow values > 0.RedisRateLimiterConfigTeststo validate fractional refill behavior.Motivation / Issue Reference:
Fixes #2145
Testing done:
Impact:
replenishRate.