Fix NPE when ServerHttpRequest.getMethod() is null in MethodRoutePredicateFactory#3958
Open
sebastian8x8 wants to merge 1 commit intospring-cloud:mainfrom
Open
Fix NPE when ServerHttpRequest.getMethod() is null in MethodRoutePredicateFactory#3958sebastian8x8 wants to merge 1 commit intospring-cloud:mainfrom
sebastian8x8 wants to merge 1 commit intospring-cloud:mainfrom
Conversation
…icateFactory Signed-off-by: Sebastian Wieseler <sebastian.wieseler@8x8.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When Spring Cloud Gateway receives a request with an unknown or unsupported HTTP method (such as a raw CONNECT request),
ServerHttpRequest.getMethod()returnsnull. The current implementation ofMethodRoutePredicateFactorydoes not check for this case, which can result in aNullPointerExceptionwhen the code tries to compare or operate on the method. This leads to a 500 Internal Server Error and exposes internal error details to clients.Resolution
This PR adds a null check for the HTTP method in the
GatewayPredicateimplementation inMethodRoutePredicateFactory. If the method isnull, the predicate now gracefully rejects the request (returnsfalse), preventing the server from throwing an exception and instead handling unsupported or malformed HTTP methods safely. This improves the robustness of the gateway and avoids leaking internal error information.Fixes:
NullPointerExceptioninMethodRoutePredicateFactory.