Make profile specific paths optional#788
Open
DanielYWoo wants to merge 7 commits intospring-cloud:mainfrom
Open
Make profile specific paths optional#788DanielYWoo wants to merge 7 commits intospring-cloud:mainfrom
DanielYWoo wants to merge 7 commits intospring-cloud:mainfrom
Conversation
Author
|
@ryanjbaxter If this is approved, how do I update the documents? |
Contributor
|
I just approved the build to run |
spencergibb
requested changes
Mar 8, 2023
Member
spencergibb
left a comment
spencergibb
left a comment
There was a problem hiding this comment.
You've made many changes, such as comments, formatting, final keywords, etc... that are unrelated to this change. Please revert them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As stated in #787 we need to mitigate the pressure to Consul, so the change is to add a new flag to get rid of profiles in a large deployment.
The change is simple, now we have a flag
spring.cloud.consul.config.profileEnabled, and default to true to keep it compatible with the current behavior. When disabled, we will scan less paths on Consul.P.S. Many of the changes are due to checkstyle, not really related to this change. I have to fix them to make the build pass.