Fix invalid YAML Environment conversion when ?resolvePlaceholders=true#3175
Open
zackman0010 wants to merge 4 commits intospring-cloud:mainfrom
Open
Fix invalid YAML Environment conversion when ?resolvePlaceholders=true#3175zackman0010 wants to merge 4 commits intospring-cloud:mainfrom
zackman0010 wants to merge 4 commits intospring-cloud:mainfrom
Conversation
Fixes invalid YAML caused by the combination of `?resolvePlaceholders=true` and `spring.cloud.config.server.encrypt.enabled = false` Signed-off-by: Zachary Sistrunk <zachary@sistrunk.dev>
The invalid YAML can be caused by any string starting with a {, not just {cipher}
Signed-off-by: Zachary Sistrunk <zachary@sistrunk.dev>
spencergibb
requested changes
Jan 6, 2026
Member
spencergibb
left a comment
There was a problem hiding this comment.
Please add a test so we can guard against regressions
Author
I've added a regression test, but I wasn't able to run it. For some reason, |
Signed-off-by: Zachary Sistrunk <zachary@sistrunk.dev>
Member
|
Yes, it's a breaking change in boot, we will take care of it |
Author
|
After merging in the latest commit from main, I was able to run my test and confirm it was successful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When converting an environment to YAML and resolving placeholders, the produced YAML will sometimes be invalid. Specifically, this happens when a placeholder is replaced with a string that starts with
{, usually{cipher}.{is a reserved character in YAML and needs to be quoted.When SnakeYAML sees a string that starts with
{, it will print it as a single-quoted string with all other strings remaining unquoted:Spring will then take this produced String and resolve the properties in it, creating invalid YAML:
This PR fixes the issue by running a second post-process step to wrap any values that start with a

{in single-quotes, matching the rest of the YAML structure. The below screenshot shows an example of the added line of code running.