Skip to content

Conversation

@kvmw
Copy link
Contributor

@kvmw kvmw commented Jan 13, 2026

This pull request fixes #1253.

It also fixes the following cases:

  • In current (before this fix) implementation, when there is a list (indexed) property with encrypted items in a property source, All lists are copied to the new decrypted property-source, not only the one that has encrypted items.

For example, in the following case only my-list should be copied to the decrypted property source but current implementation copies another-list as well.

  my-list:
    - foo: '{cipher}4ffef9'
    - foo: 'plain'
    - foo: 'another plain value'
 
  another-list:
    - bar: plain
    - bar: another plain   
  • When searching for properties, during decryption, relaxed-binding should be considered. Otherwise It is not possible to override the value of foo.text : '{cipher}4ffef9' by adding FOO_TEXT : 'updated value' in another property source with higher priority.

@kvmw kvmw marked this pull request as draft January 13, 2026 13:47
When decrypting indexed properties all items of the list with at
least one encrypted item should be copied to the new property-source but not the other lists.

When searching for properties relaxed-binding should be considered.

Signed-off-by: kvmw <mshamsi@broadcom.com>
@kvmw kvmw force-pushed the topic/kvmw/main/decrypt branch from 3e2f574 to 58fea2c Compare January 13, 2026 14:03
@kvmw kvmw marked this pull request as ready for review January 13, 2026 14:05
@ryanjbaxter
Copy link
Contributor

Could you submit this against the 4.3.x branch instead?

@kvmw
Copy link
Contributor Author

kvmw commented Jan 14, 2026

closing in favour of #1634 1634

@kvmw kvmw closed this Jan 14, 2026
@kvmw kvmw deleted the topic/kvmw/main/decrypt branch January 14, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Properties decryption not working correctly when they are on a list (yaml)

3 participants