Skip to content

Avoid expensive de-duplication in BootstrapPropertySource#getPropertyNames. #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qnnn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid expensive de-duplication in BootstrapPropertySource#getPropertyNames. #1631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions ...ext/src/main/java/org/springframework/cloud/bootstrap/config/BootstrapPropertySource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,16 @@

package org.springframework.cloud.bootstrap.config;

import java.util.Arrays;
import java.util.LinkedHashSet;
import java.util.Set;

import org.springframework.core.env.EnumerablePropertySource;
import org.springframework.core.env.PropertySource;
import org.springframework.util.StringUtils;

import static org.springframework.cloud.bootstrap.config.PropertySourceBootstrapConfiguration.BOOTSTRAP_PROPERTY_SOURCE_NAME;

/**
* Enumerable wrapper for a property source.
*
* @author Ryan Baxter
* @author Nan Chiu
*/
public class BootstrapPropertySource<T> extends EnumerablePropertySource<T> {

Expand All @@ -47,9 +43,7 @@ public Object getProperty(String name) {

@Override
public String[] getPropertyNames() {
Set<String> names = new LinkedHashSet<>(Arrays.asList(this.delegate.getPropertyNames()));

return StringUtils.toStringArray(names);
return this.delegate.getPropertyNames();
}

public PropertySource<T> getDelegate() {
Expand Down
Loading