feat: split EvaluationTrace into reason + error_code#319
Open
fabriziodemaria wants to merge 9 commits intomainfrom
Open
feat: split EvaluationTrace into reason + error_code#319fabriziodemaria wants to merge 9 commits intomainfrom
fabriziodemaria wants to merge 9 commits intomainfrom
Conversation
- Added MetricAnnotation message for custom metrics. - Extended EnumValueOptions to include metric annotations. - Refactored LibraryTraces to support multiple trace types: RequestTrace and EvaluationTrace. - Updated telemetry methods to track evaluation reasons and error codes. - Modified tests to validate new trace structures and metrics.
Made-with: Cursor
fabriziodemaria
changed the title
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Added tracking of evaluation reasons to the telemetry client in the ConfidenceFeatureProvider. This change ensures that the reason for flag resolution is logged, improving visibility into feature flag evaluations.
Align the Java SDK error mapping with the Swift SDK by adding explicit mappings for PARSE_ERROR and PROVIDER_NOT_READY instead of falling through to GENERAL. Made-with: Cursor
…errors Add RESOLVE_REASON_UNRECOGNIZED_TARGETING_RULE to resolver proto, Confidence-specific evaluation error codes to telemetry proto, map RESOLVE_REASON_STALE and use granular error codes instead of generic EVALUATION_ERROR_CODE_GENERAL. Also upgrade google-java-format to 1.35.0 to fix JDK 25 build compatibility. Made-with: Cursor
…DK 17 The override requires JDK 22+ but CI runs on JDK 17, causing `JCTree$JCAnyPattern` class-not-found failures. Reverting to the fmt-maven-plugin 2.25 bundled formatter (1.24.0) and restoring the original string-wrapping style it expects. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the Java SDK telemetry with the updated proto: splits evaluation tracking into separate
reasonanderror_codefields for finer-grained metrics.EvaluationReason+EvaluationErrorCodeper evaluationgetEvaluationandgetEvaluationFuturetelemetry.protowithEvaluationTracecontainingEvaluationReasonandEvaluationErrorCodeenumsRelated PRs
Test plan
ConfidenceIntegrationTestandFeatureProviderTest