CSPL-4358 Split BusConfiguration CR into 2 CRs - Queue and ObjectStorage#1643
CSPL-4358 Split BusConfiguration CR into 2 CRs - Queue and ObjectStorage#1643kasiakoziol wants to merge 7 commits intoCSPL-3551-ingestion-crfrom
Conversation
Pull Request Test Coverage Report for Build 20365107317Details
💛 - Coveralls |
| case "BusConfiguration": | ||
| latestBusCR := &enterpriseApi.BusConfiguration{} | ||
| err = client.Get(ctx, namespacedName, latestBusCR) | ||
| case "Queue": |
There was a problem hiding this comment.
I am not sure we should take responsibility for updating the queue or object storage, or for adding any controller logic or status updates for them. The only thing we are doing is reading the queue and object storage CRs and using their data as a reference in the ingestor and indexer. I think we should not add any controllers for these 2 specs that is the work for structure storage only when they want to actively manage them.
another point is asking customers for creating these custom resources, i know there is no other option, but I am a bit concerned that we are asking customers to provide a full CR spec.
There was a problem hiding this comment.
Regarding controllers, I responded in another thread.
Regarding creating these CR specs, then how do you see this happen in a different way, not provided by the customer? We have no other way to get this information.
Depends On
Description
It splits BusConfiguration CR into 2 CRs - Queue and ObjectStorage as per internal documentation.
Key Changes
Testing and Verification
Related Issues
Jira: https://splunk.atlassian.net/browse/CSPL-4358
PR Checklist