Conversation
|
Presently marked as draft since this requires some other pending changes in the repo 😄 |
| "./schemas/CSVLookup.schema.json": "lookups/csv/*.yml", | ||
| "./schemas/Dashboard.schema.json": "dashboards/*.yml", | ||
| "./schemas/DataSource.schema.json": "data_sources/*.yml", | ||
| "./schemas/EventBasedDetection.schema.json": ["detections/*.yml", "!removed/detections/*.yml"], |
There was a problem hiding this comment.
We will intentionally not keep removed content in line with updates to the spec. Removed content should only be validated based on fields required for "RemovedContent" which we already have on line 11. I believe this second path (removed/detections/*.yml) should be removed.
There was a problem hiding this comment.
When I removed the !removed/detections/*.yml, the files under e.g. removed/detections/*.yml get validated by both schema (RemovedContent.schema.json and EventBasedDetection.schema.json). Since we only want the removed content to be validated against the RemovedContent.schema.json, I explicitly specify for schema e.g. EventBasedDetection.schema.json don't validate files under removed directory.
74c7ba6 to
0922ef1
Compare
Details
Checklist
<platform>_<mitre att&ck technique>_<short description>nomenclatureNotes For Submitters and Reviewers
buildCI job when it fails will likely show an error about what is failing. You may have a very descriptive error of the specific field(s) in the specific file(s) that is causing an issue. In some cases, its also possible there is an issue with the YAML. Many of these can be caught with the pre-commit hooks if you set them up. These errors will be less descriptive as to what exactly is wrong, but will give you a column and row position in a specific file where the YAML processing breaks. If you're having trouble with this, feel free to add a comment to your PR tagging one of the maintainers and we'll be happy to help troubleshoot it.