chore: ADDON-80802 PSA implementation with uuid flag#906
Open
spanchal-crest wants to merge 5 commits intodevelopfrom
Open
chore: ADDON-80802 PSA implementation with uuid flag#906spanchal-crest wants to merge 5 commits intodevelopfrom
spanchal-crest wants to merge 5 commits intodevelopfrom
Conversation
spanchal-crest
requested review from
asaste-splunk,
lplonka-splunk,
mgazda-splunk and
spancholi-crest
spanchal-crest
force-pushed
the
spanchal/ADDON-80802-psa-implementation-using-uuid
branch
from
91f22e9 to
baf6cf0
Compare
mgazda-splunk
previously approved these changes
Jun 25, 2025
Contributor
mgazda-splunk
left a comment
mgazda-splunk
left a comment
There was a problem hiding this comment.
I am OK with that. But not having full picture so owning team should verify.
|
|
||
| def __ingest(self, data): | ||
| try: | ||
| batch_data = "\n".join(json.dumps(obj) for obj in data) |
Contributor
There was a problem hiding this comment.
Why do we need to batch here?
Author
There was a problem hiding this comment.
Hi Michal, this change was done by you for sending the events to EP and merged to develop but it is not yet merged to main. My MR is against main and I wanted this code change to test the KO with SPL2 in workflow. So added this code in my MR.
Your MR: https://github.com/splunk/pytest-splunk-addon/pull/904/files
spanchal-crest
force-pushed
the
spanchal/ADDON-80802-psa-implementation-using-uuid
branch
2 times, most recently
from
3ef7f06 to
739878c
Compare
spanchal-crest
requested review from
dvarasani-crest,
harshilgajera-crest and
mgazda-splunk
tests/unit/tests_standard_lib/test_fields_tests/test_test_generator.py
Outdated
Show resolved
Hide resolved
spanchal-crest
force-pushed
the
spanchal/ADDON-80802-psa-implementation-using-uuid
branch
from
8f9f7c1 to
4442f69
Compare
spanchal-crest
force-pushed
the
spanchal/ADDON-80802-psa-implementation-using-uuid
branch
from
4442f69 to
02fbca3
Compare
spanchal-crest
force-pushed
the
spanchal/ADDON-80802-psa-implementation-using-uuid
branch
from
02fbca3 to
bc1e289
Compare
Contributor
|
can you also add the e2e tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, PSA uses the raw event in the search query for the “test_requirements_fields” test. So, in order to run the test for SPL2 transformed events, the logs repo samples needs to be updated with the SPL2 transformed logs. To avoid updating the logs repo samples, we can update the search query in PSA to use a unique uuid instead of using the raw event by using the uuid flag.
JIRA: https://splunk.atlassian.net/browse/ADDON-80802