New strongly typed provider constructor#26
Open
finneg23 wants to merge 1 commit intosplitio:developmentfrom
Open
New strongly typed provider constructor#26finneg23 wants to merge 1 commit intosplitio:developmentfrom
finneg23 wants to merge 1 commit intosplitio:developmentfrom
Conversation
Contributor
|
Hi @finneg23, Thanks for your suggestions. While reviewing your PR, I noticed that the provider wasn’t following the same pattern we implemented in the others, so I took advantage of that along with your feedback and released a new version of the provider (2.1.0) . Example of how to use it: var config = new ConfigurationOptions();
var splitClient = new SplitFactory("YOUR_API_KEY", config).Client();
try
{
splitClient.BlockUntilReady(10000); // wait up to 10 seconds for SDK to be ready
}
catch (Exception ex)
{
// log & handle
}
await Api.Instance.SetProviderAsync(new Provider(splitClient));if that works for you, give it a try and let me know your feedback - we can close the PR whenever you feel it's appropriate. Best regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds in a clearer option for constructing a Provider that offers better visibility into initializing the SDK while mostly just facading for the original implementation.