Patch WebsocketClient to work with any websockets version >= 10.0#136
Merged
dumitrugutu merged 2 commits intomasterfrom Jul 3, 2025
Merged
Patch WebsocketClient to work with any websockets version >= 10.0#136dumitrugutu merged 2 commits intomasterfrom
dumitrugutu merged 2 commits intomasterfrom
Conversation
dumitrugutu
force-pushed
the
unpin-websockets-version
branch
3 times, most recently
from
2ce9909 to
2fa417f
Compare
dumitrugutu
force-pushed
the
unpin-websockets-version
branch
from
2fa417f to
dec377c
Compare
TudorCRL
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In previous versions we required websockets version >= 14 which caused issues when using the package alongside other sdk which required websockets < 14.0. This PR fixes that by downgrading the required version to >= 10.0 and dynamically setting the correct ws header param
extra_headersoradditional_headersfor the installed version.