Linear time list operations#10
Merged
Merged
Conversation
Signed-off-by: Harmen Stoppels <me@harmenstoppels.nl>
Signed-off-by: Harmen Stoppels <me@harmenstoppels.nl>
Signed-off-by: Harmen Stoppels <me@harmenstoppels.nl>
sethrj
approved these changes
May 15, 2026
sethrj
left a comment
There was a problem hiding this comment.
Very nice! Good testing and clever scripting.
kwryankrattiger
approved these changes
May 18, 2026
Collaborator
kwryankrattiger
left a comment
There was a problem hiding this comment.
Looks good, the expected/result are consistent for all of the tests look correct.
I ran all of the test and the benchmark before and after these changes and found one bug in the old preextend command that was double prepending the PREFIX. The speed up for the benchmark as about 4x which is pretty good.
Member
Author
|
You're right. I think preextend was over-engineered, cause the bug case is never hit (no prefix is every passed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids string concatenation overhead in extend and preextend
"tricks" used:
set --and"$*"with differentIFSfor fast concatenation, presumably linear complexity.In the included benchmark, runtime goes from 100ms to 21ms on my macbook.