Support compiling a specific subschema in compile and validate#646
Merged
Support compiling a specific subschema in compile and validate#646
compile and validate#646Conversation
0fb5060 to
78b7832
Compare
🤖 Augment PR SummarySummary: Adds support for compiling/validating against a specific subschema via a new Changes:
Technical Notes: Pointer and fragment-only entrypoints are converted into an absolute URI by attaching the pointer as the schema root URI fragment before compilation. 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
4 issues found across 22 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="test/validate/pass_entrypoint_pointer_fragment.sh">
<violation number="1" location="test/validate/pass_entrypoint_pointer_fragment.sh:27">
P3: Capture and assert stdout as well as stderr so verbose tests detect unexpected output on either stream.
(Based on your team's feedback about capturing stdout and stderr in verbose tests.) [FEEDBACK_USED]</violation>
</file>
<file name="test/validate/pass_entrypoint_pointer.sh">
<violation number="1" location="test/validate/pass_entrypoint_pointer.sh:27">
P2: Capture and assert stdout as well as stderr in this verbose test; otherwise unexpected stdout output will be missed.
(Based on your team's feedback about capturing stdout and stderr using verbose tests.) [FEEDBACK_USED]</violation>
</file>
<file name="test/validate/pass_entrypoint_uri.sh">
<violation number="1" location="test/validate/pass_entrypoint_uri.sh:28">
P2: Capture stdout as well when running the verbose validate command, and assert it is empty to detect unexpected output.
(Based on your team's feedback about capturing stdout and stderr using verbose tests.) [FEEDBACK_USED]</violation>
</file>
<file name="test/validate/fail_entrypoint_mismatch.sh">
<violation number="1" location="test/validate/fail_entrypoint_mismatch.sh:27">
P3: Capture and assert stdout for the verbose failure case so the test detects unexpected output on either stream.
(Based on your team's feedback about capturing stdout and stderr using verbose tests.) [FEEDBACK_USED]</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
See: #639 Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
78b7832 to
334f69d
Compare
compile and validatecompile and validate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #639
Signed-off-by: Juan Cruz Viotti jv@jviotti.com