Skip to content

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Jan 30, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode
Copy link

augmentcode bot commented Jan 30, 2026

🤖 Augment PR Summary

Summary: Updates the vendored sourcemeta/core dependency to commit 4e9d280a8a45…, bringing in SchemaFrame improvements and JSON Pointer container support changes.

Changes:

  • Bumped the core SHA in DEPENDENCIES and synced the corresponding vendored sources.
  • Removed the std::hash specialization for JSON Pointers; added explicit Pointer::Hasher/Comparator (including reference-wrapper support) for unordered containers.
  • Added fast pointer-based lookups in SchemaFrame via an internal pointer→locations cache and a new traverse(pointer, LocationType) overload.
  • Extended location metadata with an orphan flag and included it in SchemaFrame::to_json() output.
  • Implemented reachability analysis (SchemaFrame::is_reachable) to determine which locations could be evaluated during validation.
  • Updated schema transformer traversal to use the explicit pointer hasher for visited sets.
  • Adjusted AlterSchema rules: OrphanDefinitions now uses reachability to remove only truly unreachable definitions; EmptyObjectAsTrue no longer forces a reframe after transforming.

Technical Notes: SchemaFrame is now non-copyable/non-movable to prevent internal cache dangling; instantiate per analysis and pass by reference where needed.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@jviotti jviotti merged commit 5e0e10c into main Jan 30, 2026
13 checks passed
@jviotti jviotti deleted the msvc-fix branch January 30, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants