Misc improvements to the `stacktrace` module by jviotti · Pull Request #2429 · sourcemeta/core

jviotti · 2026-05-26T23:48:45Z

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

cubic-dev-ai

1 issue found across 3 files

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

augmentcode · 2026-05-26T23:52:21Z

🤖 Augment PR Summary

Summary: Misc improvements to the stacktrace module to make symbol resolution and crash tracing more reliable across platforms.
Changes:

macOS: use -Wl,-export_dynamic instead of -rdynamic when linking consumers.
POSIX: avoid UB in address-offset math; use REG_RIP for Linux x86_64 crash PC extraction; document and export crash_handler for dladdr.
Windows: serialize dbghelp symbol lookups with a mutex and allow retry when SymInitialize fails.

_{🤖 Was this summary useful? React with 👍 or 👎}

augmentcode

Review completed. 2 suggestions posted.

Comment augment review to trigger a new review at any time.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

github-actions

Benchmark (macos/llvm)

Details

Benchmark suite	Current: `e0ffa53`	Previous: `36e031f`	Ratio
`Regex_Lower_S_Or_Upper_S_Asterisk`	`1.9308343094423526` ns/iter	`1.9797968983682277` ns/iter	`0.98`
`Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar`	`1.5938995822809234` ns/iter	`1.6979315387397986` ns/iter	`0.94`
`Regex_Period_Asterisk`	`1.5690247432492153` ns/iter	`1.659140493877612` ns/iter	`0.95`
`Regex_Group_Period_Asterisk_Group`	`1.5868032124849167` ns/iter	`1.6691348865322386` ns/iter	`0.95`
`Regex_Period_Plus`	`1.882266445400284` ns/iter	`2.035180405465495` ns/iter	`0.92`
`Regex_Period`	`1.9357513334357626` ns/iter	`1.9821992603931127` ns/iter	`0.98`
`Regex_Caret_Period_Plus_Dollar`	`1.888694347136014` ns/iter	`2.0191638194521855` ns/iter	`0.94`
`Regex_Caret_Group_Period_Plus_Group_Dollar`	`1.8979000379554531` ns/iter	`2.031384117110806` ns/iter	`0.93`
`Regex_Caret_Period_Asterisk_Dollar`	`1.5677543175676758` ns/iter	`1.6590257064209066` ns/iter	`0.94`
`Regex_Caret_Group_Period_Asterisk_Group_Dollar`	`1.6147180731655815` ns/iter	`1.7092049096598996` ns/iter	`0.94`
`Regex_Caret_X_Hyphen`	`5.637372054283378` ns/iter	`5.940291030158957` ns/iter	`0.95`
`Regex_Period_Md_Dollar`	`15.360906724794285` ns/iter	`16.4561280373471` ns/iter	`0.93`
`Regex_Caret_Slash_Period_Asterisk`	`7.812709322705473` ns/iter	`7.875374029962451` ns/iter	`0.99`
`Regex_Caret_Period_Range_Dollar`	`1.6154335970866713` ns/iter	`1.6793296398365636` ns/iter	`0.96`
`Regex_Nested_Backtrack`	`23.71208978014259` ns/iter	`24.641291560843683` ns/iter	`0.96`
`JSON_Array_Of_Objects_Unique`	`432.77982478630554` ns/iter	`421.3844599919813` ns/iter	`1.03`
`JSON_Parse_1`	`3922.886237536716` ns/iter	`3820.8669011396873` ns/iter	`1.03`
`JSON_Parse_Real`	`6137.407223776654` ns/iter	`6426.220334474172` ns/iter	`0.96`
`JSON_Parse_Decimal`	`7504.969496289597` ns/iter	`7882.355197217868` ns/iter	`0.95`
`JSON_Parse_Schema_ISO_Language`	`2864053.91020406` ns/iter	`2946234.223301068` ns/iter	`0.97`
`JSON_Fast_Hash_Helm_Chart_Lock`	`54.47135928424098` ns/iter	`58.339852033761716` ns/iter	`0.93`
`JSON_Equality_Helm_Chart_Lock`	`124.59362508378017` ns/iter	`131.64194973195086` ns/iter	`0.95`
`JSON_Divisible_By_Decimal`	`160.74963875753286` ns/iter	`178.62608440685472` ns/iter	`0.90`
`JSON_String_Equal/10`	`6.269147312467637` ns/iter	`6.610010965918086` ns/iter	`0.95`
`JSON_String_Equal/100`	`6.012331104047299` ns/iter	`6.449322069837482` ns/iter	`0.93`
`JSON_String_Equal_Small_By_Perfect_Hash/10`	`0.7040540906452113` ns/iter	`0.7473535622113533` ns/iter	`0.94`
`JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10`	`3.025467091234837` ns/iter	`3.3270729072987355` ns/iter	`0.91`
`JSON_String_Fast_Hash/10`	`2.1959564314835927` ns/iter	`2.375259358056866` ns/iter	`0.92`
`JSON_String_Fast_Hash/100`	`2.15486147272132` ns/iter	`1.9792354475982397` ns/iter	`1.09`
`JSON_String_Key_Hash/10`	`1.3965899592038864` ns/iter	`1.3547431197415127` ns/iter	`1.03`
`JSON_String_Key_Hash/100`	`2.248914644652081` ns/iter	`2.135870324036406` ns/iter	`1.05`
`JSON_Object_Defines_Miss_Same_Length`	`2.5825680798741257` ns/iter	`2.310157527631496` ns/iter	`1.12`
`JSON_Object_Defines_Miss_Too_Small`	`2.5588973971133515` ns/iter	`2.3773674119707247` ns/iter	`1.08`
`JSON_Object_Defines_Miss_Too_Large`	`2.563497826490502` ns/iter	`2.3689504834281383` ns/iter	`1.08`
`Pointer_Object_Traverse`	`16.015257643965484` ns/iter	`13.792144561373023` ns/iter	`1.16`
`Pointer_Object_Try_Traverse`	`19.4926546897795` ns/iter	`19.248021971415966` ns/iter	`1.01`
`Pointer_Push_Back_Pointer_To_Weak_Pointer`	`155.39193737260172` ns/iter	`150.2636358946191` ns/iter	`1.03`
`Pointer_Walker_Schema_ISO_Language`	`4412787.128205473` ns/iter	`4059624.7391301817` ns/iter	`1.09`
`Pointer_Maybe_Tracked_Deeply_Nested/0`	`1000364.9662576696` ns/iter	`1000122.0552700515` ns/iter	`1.00`
`Pointer_Maybe_Tracked_Deeply_Nested/1`	`1530130.895716959` ns/iter	`1294296.1104761793` ns/iter	`1.18`
`Pointer_Position_Tracker_Get_Deeply_Nested`	`442.08322894387` ns/iter	`354.64026561034996` ns/iter	`1.25`
`URITemplateRouter_Create`	`21971.307095417586` ns/iter	`22922.65186804747` ns/iter	`0.96`
`URITemplateRouter_Match`	`155.69638905852088` ns/iter	`159.6343348697095` ns/iter	`0.98`
`URITemplateRouter_Match_BasePath`	`180.3734553581552` ns/iter	`194.38902736793256` ns/iter	`0.93`
`URITemplateRouterView_Restore`	`8597.767829126724` ns/iter	`10160.209104423138` ns/iter	`0.85`
`URITemplateRouterView_Match`	`121.39284674315046` ns/iter	`131.31038326591667` ns/iter	`0.92`
`URITemplateRouterView_Match_BasePath`	`136.91635939399063` ns/iter	`150.36733561828248` ns/iter	`0.91`
`URITemplateRouterView_Arguments`	`378.0485479060537` ns/iter	`396.5644091874416` ns/iter	`0.95`
`JSONL_Parse_Large`	`11331023.229508603` ns/iter	`12134184.929823676` ns/iter	`0.93`
`JSONL_Parse_Large_GZIP`	`12049836.864406897` ns/iter	`12682018.607141083` ns/iter	`0.95`
`HTML_Build_Table_100000`	`66420814.36363738` ns/iter	`64684533.40000906` ns/iter	`1.03`
`HTML_Render_Table_100000`	`2338468.7500000885` ns/iter	`3233807.0000005243` ns/iter	`0.72`
`GZIP_Compress_ISO_Language_Set_3_Locations`	`25930791.666665014` ns/iter	`27817540.038462047` ns/iter	`0.93`
`GZIP_Decompress_ISO_Language_Set_3_Locations`	`4522990.384615265` ns/iter	`5079760.72058829` ns/iter	`0.89`
`GZIP_Compress_ISO_Language_Set_3_Schema`	`1413627.1834677283` ns/iter	`1519942.7738592424` ns/iter	`0.93`
`GZIP_Decompress_ISO_Language_Set_3_Schema`	`271295.130979498` ns/iter	`290481.43305439124` ns/iter	`0.93`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

Benchmark (linux/gcc)

Details

Benchmark suite	Current: `e0ffa53`	Previous: `36e031f`	Ratio
`GZIP_Compress_ISO_Language_Set_3_Locations`	`39015891.11111055` ns/iter	`41275365.23529162` ns/iter	`0.95`
`GZIP_Decompress_ISO_Language_Set_3_Locations`	`4643662.985915613` ns/iter	`4562366.224358782` ns/iter	`1.02`
`GZIP_Compress_ISO_Language_Set_3_Schema`	`2076963.035714284` ns/iter	`2335843.3999999305` ns/iter	`0.89`
`GZIP_Decompress_ISO_Language_Set_3_Schema`	`396398.92953776015` ns/iter	`298288.32156695623` ns/iter	`1.33`
`HTML_Build_Table_100000`	`58830706.49999904` ns/iter	`67166036.33333308` ns/iter	`0.88`
`HTML_Render_Table_100000`	`1832882.1596859293` ns/iter	`1936659.3128491614` ns/iter	`0.95`
`JSONL_Parse_Large`	`12780484.799999282` ns/iter	`11944246.169491634` ns/iter	`1.07`
`JSONL_Parse_Large_GZIP`	`13992835.799999738` ns/iter	`13299212.188679524` ns/iter	`1.05`
`URITemplateRouter_Create`	`30357.839343694402` ns/iter	`29789.21909920526` ns/iter	`1.02`
`URITemplateRouter_Match`	`174.41830296782967` ns/iter	`175.14356692121717` ns/iter	`1.00`
`URITemplateRouter_Match_BasePath`	`198.09436482467285` ns/iter	`205.0801555980222` ns/iter	`0.97`
`URITemplateRouterView_Restore`	`7615.84860549126` ns/iter	`8655.662847154561` ns/iter	`0.88`
`URITemplateRouterView_Match`	`140.60428212938146` ns/iter	`131.5725583060951` ns/iter	`1.07`
`URITemplateRouterView_Match_BasePath`	`162.31368682360002` ns/iter	`155.65677519505226` ns/iter	`1.04`
`URITemplateRouterView_Arguments`	`475.1813156320065` ns/iter	`456.7797064725423` ns/iter	`1.04`
`Pointer_Object_Traverse`	`26.57605376611514` ns/iter	`27.605783028312704` ns/iter	`0.96`
`Pointer_Object_Try_Traverse`	`22.456002047119647` ns/iter	`22.093839335687413` ns/iter	`1.02`
`Pointer_Push_Back_Pointer_To_Weak_Pointer`	`153.1387887575891` ns/iter	`171.19045529977865` ns/iter	`0.89`
`Pointer_Walker_Schema_ISO_Language`	`3284969.9906541454` ns/iter	`3379726.3864734536` ns/iter	`0.97`
`Pointer_Maybe_Tracked_Deeply_Nested/0`	`1603423.8302752497` ns/iter	`1532553.1315789134` ns/iter	`1.05`
`Pointer_Maybe_Tracked_Deeply_Nested/1`	`1808124.5064936352` ns/iter	`1729271.5896806647` ns/iter	`1.05`
`Pointer_Position_Tracker_Get_Deeply_Nested`	`512.4486770870528` ns/iter	`597.3823243254168` ns/iter	`0.86`
`JSON_Array_Of_Objects_Unique`	`424.44924029990136` ns/iter	`467.7520937532362` ns/iter	`0.91`
`JSON_Parse_1`	`7954.510503584793` ns/iter	`7769.232305342434` ns/iter	`1.02`
`JSON_Parse_Real`	`12082.469004839064` ns/iter	`12243.748579472878` ns/iter	`0.99`
`JSON_Parse_Decimal`	`17827.692600681414` ns/iter	`16488.432922236647` ns/iter	`1.08`
`JSON_Parse_Schema_ISO_Language`	`4574099.281046009` ns/iter	`4551364.803921545` ns/iter	`1.00`
`JSON_Fast_Hash_Helm_Chart_Lock`	`71.62591942826116` ns/iter	`77.26754360555442` ns/iter	`0.93`
`JSON_Equality_Helm_Chart_Lock`	`150.62291142841633` ns/iter	`191.72245607160565` ns/iter	`0.79`
`JSON_Divisible_By_Decimal`	`238.36696278247345` ns/iter	`228.74218837353672` ns/iter	`1.04`
`JSON_String_Equal/10`	`5.725058955122615` ns/iter	`5.815294561307193` ns/iter	`0.98`
`JSON_String_Equal/100`	`6.367642962215219` ns/iter	`6.811116231764637` ns/iter	`0.93`
`JSON_String_Equal_Small_By_Perfect_Hash/10`	`0.6240385201282708` ns/iter	`0.719028386734658` ns/iter	`0.87`
`JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10`	`25.196867314382416` ns/iter	`21.93758915631119` ns/iter	`1.15`
`JSON_String_Fast_Hash/10`	`1.557521209566731` ns/iter	`1.7885695189556523` ns/iter	`0.87`
`JSON_String_Fast_Hash/100`	`1.557105939404712` ns/iter	`1.7595197657029078` ns/iter	`0.88`
`JSON_String_Key_Hash/10`	`1.2460745004938516` ns/iter	`1.0831409896909552` ns/iter	`1.15`
`JSON_String_Key_Hash/100`	`12.438637846968408` ns/iter	`14.766340973856089` ns/iter	`0.84`
`JSON_Object_Defines_Miss_Same_Length`	`3.4249741910118274` ns/iter	`3.8695614670412817` ns/iter	`0.89`
`JSON_Object_Defines_Miss_Too_Small`	`3.1126712350632673` ns/iter	`3.517928208390581` ns/iter	`0.88`
`JSON_Object_Defines_Miss_Too_Large`	`3.7452576755760054` ns/iter	`4.390477231442642` ns/iter	`0.85`
`Regex_Lower_S_Or_Upper_S_Asterisk`	`0.6226064977713948` ns/iter	`0.7345425703493541` ns/iter	`0.85`
`Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar`	`0.6232354000002872` ns/iter	`0.703706290212344` ns/iter	`0.89`
`Regex_Period_Asterisk`	`0.9346950236202942` ns/iter	`1.0550987822958702` ns/iter	`0.89`
`Regex_Group_Period_Asterisk_Group`	`0.9344812263328023` ns/iter	`1.0553412463373415` ns/iter	`0.89`
`Regex_Period_Plus`	`0.6231188346456435` ns/iter	`0.7031717568187137` ns/iter	`0.89`
`Regex_Period`	`0.6230959864838873` ns/iter	`0.7034415392776244` ns/iter	`0.89`
`Regex_Caret_Period_Plus_Dollar`	`0.93439216063385` ns/iter	`1.0559080247243364` ns/iter	`0.88`
`Regex_Caret_Group_Period_Plus_Group_Dollar`	`0.9342250275735182` ns/iter	`1.0582918872495908` ns/iter	`0.88`
`Regex_Caret_Period_Asterisk_Dollar`	`0.6230014535789554` ns/iter	`0.7149049884754252` ns/iter	`0.87`
`Regex_Caret_Group_Period_Asterisk_Group_Dollar`	`0.6226406824554312` ns/iter	`0.7031903044115702` ns/iter	`0.89`
`Regex_Caret_X_Hyphen`	`4.051469240834752` ns/iter	`3.5170237398558735` ns/iter	`1.15`
`Regex_Period_Md_Dollar`	`28.442884093042753` ns/iter	`33.2349648129579` ns/iter	`0.86`
`Regex_Caret_Slash_Period_Asterisk`	`4.669219478190197` ns/iter	`4.585993920277671` ns/iter	`1.02`
`Regex_Caret_Period_Range_Dollar`	`0.7786693293595421` ns/iter	`0.8402284008319019` ns/iter	`0.93`
`Regex_Nested_Backtrack`	`36.10471024466496` ns/iter	`40.913691121234244` ns/iter	`0.88`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

Benchmark (linux/llvm)

Details

Benchmark suite	Current: `e0ffa53`	Previous: `36e031f`	Ratio
`Regex_Lower_S_Or_Upper_S_Asterisk`	`2.1997803750118288` ns/iter	`2.465690656514107` ns/iter	`0.89`
`Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar`	`2.2081227546780378` ns/iter	`2.4646868698968003` ns/iter	`0.90`
`Regex_Period_Asterisk`	`2.1805432600895576` ns/iter	`2.4734979563250716` ns/iter	`0.88`
`Regex_Group_Period_Asterisk_Group`	`2.1913239889074814` ns/iter	`2.4627914869636154` ns/iter	`0.89`
`Regex_Period_Plus`	`2.4905047563034213` ns/iter	`3.1951560797312597` ns/iter	`0.78`
`Regex_Period`	`2.8012058340322064` ns/iter	`2.4633870440007097` ns/iter	`1.14`
`Regex_Caret_Period_Plus_Dollar`	`2.490878320770365` ns/iter	`2.4624970641756208` ns/iter	`1.01`
`Regex_Caret_Group_Period_Plus_Group_Dollar`	`2.800898412005186` ns/iter	`2.462142245887773` ns/iter	`1.14`
`Regex_Caret_Period_Asterisk_Dollar`	`3.1109826468493793` ns/iter	`3.514985513633416` ns/iter	`0.89`
`Regex_Caret_Group_Period_Asterisk_Group_Dollar`	`3.422569700817422` ns/iter	`3.869173805770761` ns/iter	`0.88`
`Regex_Caret_X_Hyphen`	`6.540623007491339` ns/iter	`6.68429263113317` ns/iter	`0.98`
`Regex_Period_Md_Dollar`	`27.710567233850607` ns/iter	`26.65270260767588` ns/iter	`1.04`
`Regex_Caret_Slash_Period_Asterisk`	`6.848580916397438` ns/iter	`5.801386807129276` ns/iter	`1.18`
`Regex_Caret_Period_Range_Dollar`	`3.868496627476675` ns/iter	`4.2182303788077` ns/iter	`0.92`
`Regex_Nested_Backtrack`	`37.001114815350185` ns/iter	`36.67349960548736` ns/iter	`1.01`
`JSON_Array_Of_Objects_Unique`	`420.99058671840135` ns/iter	`439.0920388946588` ns/iter	`0.96`
`JSON_Parse_1`	`5874.688479348722` ns/iter	`5676.727208952972` ns/iter	`1.03`
`JSON_Parse_Real`	`10888.74646342845` ns/iter	`10330.064707790421` ns/iter	`1.05`
`JSON_Parse_Decimal`	`11074.31196594779` ns/iter	`11387.9071081605` ns/iter	`0.97`
`JSON_Parse_Schema_ISO_Language`	`3609280.752577091` ns/iter	`3679614.691099368` ns/iter	`0.98`
`JSON_Fast_Hash_Helm_Chart_Lock`	`61.05572333475074` ns/iter	`73.52322392395612` ns/iter	`0.83`
`JSON_Equality_Helm_Chart_Lock`	`171.08057163826416` ns/iter	`166.44749245831684` ns/iter	`1.03`
`JSON_Divisible_By_Decimal`	`246.11023498794688` ns/iter	`243.87666178146597` ns/iter	`1.01`
`JSON_String_Equal/10`	`6.230755962130255` ns/iter	`5.982528224208631` ns/iter	`1.04`
`JSON_String_Equal/100`	`6.856904626533252` ns/iter	`6.686715902364479` ns/iter	`1.03`
`JSON_String_Equal_Small_By_Perfect_Hash/10`	`0.9360605735060543` ns/iter	`1.0546504543421884` ns/iter	`0.89`
`JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10`	`10.273783605540102` ns/iter	`12.40424529457293` ns/iter	`0.83`
`JSON_String_Fast_Hash/10`	`2.803717364524902` ns/iter	`2.814814452898971` ns/iter	`1.00`
`JSON_String_Fast_Hash/100`	`2.82317551229574` ns/iter	`2.816884403789142` ns/iter	`1.00`
`JSON_String_Key_Hash/10`	`2.1812060089349865` ns/iter	`2.4622280546094517` ns/iter	`0.89`
`JSON_String_Key_Hash/100`	`6.5380836958078055` ns/iter	`7.735207493697851` ns/iter	`0.85`
`JSON_Object_Defines_Miss_Same_Length`	`3.741557535875271` ns/iter	`4.221312968135381` ns/iter	`0.89`
`JSON_Object_Defines_Miss_Too_Small`	`3.7423504338888134` ns/iter	`4.224776486612772` ns/iter	`0.89`
`JSON_Object_Defines_Miss_Too_Large`	`3.742377046143413` ns/iter	`4.22196544572977` ns/iter	`0.89`
`Pointer_Object_Traverse`	`24.384746050064447` ns/iter	`27.332545651501583` ns/iter	`0.89`
`Pointer_Object_Try_Traverse`	`26.15661022445127` ns/iter	`30.21217326799553` ns/iter	`0.87`
`Pointer_Push_Back_Pointer_To_Weak_Pointer`	`160.27084918121326` ns/iter	`175.46151140786714` ns/iter	`0.91`
`Pointer_Walker_Schema_ISO_Language`	`3022778.0085468106` ns/iter	`3166081.940639119` ns/iter	`0.95`
`Pointer_Maybe_Tracked_Deeply_Nested/0`	`1468422.1666665631` ns/iter	`1411302.2729123754` ns/iter	`1.04`
`Pointer_Maybe_Tracked_Deeply_Nested/1`	`1877393.603217082` ns/iter	`1744362.9330024512` ns/iter	`1.08`
`Pointer_Position_Tracker_Get_Deeply_Nested`	`616.3568924766292` ns/iter	`609.3447344030094` ns/iter	`1.01`
`URITemplateRouter_Create`	`31807.87517556601` ns/iter	`30635.627795664906` ns/iter	`1.04`
`URITemplateRouter_Match`	`169.82806848374682` ns/iter	`173.42227487013355` ns/iter	`0.98`
`URITemplateRouter_Match_BasePath`	`199.88088297910852` ns/iter	`211.5566696851925` ns/iter	`0.94`
`URITemplateRouterView_Restore`	`7723.0734945271115` ns/iter	`8698.056029518926` ns/iter	`0.89`
`URITemplateRouterView_Match`	`144.33627849975443` ns/iter	`144.4853124963858` ns/iter	`1.00`
`URITemplateRouterView_Match_BasePath`	`163.32834895489415` ns/iter	`165.39991603390337` ns/iter	`0.99`
`URITemplateRouterView_Arguments`	`474.7369191942784` ns/iter	`469.89575890127804` ns/iter	`1.01`
`JSONL_Parse_Large`	`10974802.671874784` ns/iter	`9871410.239437044` ns/iter	`1.11`
`JSONL_Parse_Large_GZIP`	`12223789.017241416` ns/iter	`11184235.539682655` ns/iter	`1.09`
`HTML_Build_Table_100000`	`63783904.63636275` ns/iter	`85295598.87499972` ns/iter	`0.75`
`HTML_Render_Table_100000`	`5522499.376000269` ns/iter	`5310420.122137685` ns/iter	`1.04`
`GZIP_Compress_ISO_Language_Set_3_Locations`	`34031725.4761896` ns/iter	`36448494.31578666` ns/iter	`0.93`
`GZIP_Decompress_ISO_Language_Set_3_Locations`	`5057635.170001049` ns/iter	`4821600.780822068` ns/iter	`1.05`
`GZIP_Compress_ISO_Language_Set_3_Schema`	`1892612.8027026828` ns/iter	`2125511.0820668763` ns/iter	`0.89`
`GZIP_Decompress_ISO_Language_Set_3_Schema`	`379024.4807169519` ns/iter	`289571.8701406154` ns/iter	`1.31`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

Benchmark (windows/msvc)

Details

Benchmark suite	Current: `e0ffa53`	Previous: `36e031f`	Ratio
`Regex_Lower_S_Or_Upper_S_Asterisk`	`7.582136160713762` ns/iter	`6.845947544642833` ns/iter	`1.11`
`Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar`	`7.623425223215463` ns/iter	`6.888919642857364` ns/iter	`1.11`
`Regex_Period_Asterisk`	`7.504112723214971` ns/iter	`6.86874553571418` ns/iter	`1.09`
`Regex_Group_Period_Asterisk_Group`	`7.497002232142844` ns/iter	`6.964492857143512` ns/iter	`1.08`
`Regex_Period_Plus`	`9.677302188939738` ns/iter	`8.761945943027126` ns/iter	`1.10`
`Regex_Period`	`9.67404236752664` ns/iter	`8.84736022836096` ns/iter	`1.09`
`Regex_Caret_Period_Plus_Dollar`	`9.692699956728699` ns/iter	`8.836210937499851` ns/iter	`1.10`
`Regex_Caret_Group_Period_Plus_Group_Dollar`	`9.683451562500167` ns/iter	`8.772571428571194` ns/iter	`1.10`
`Regex_Caret_Period_Asterisk_Dollar`	`7.528875892857302` ns/iter	`6.888215401786065` ns/iter	`1.09`
`Regex_Caret_Group_Period_Asterisk_Group_Dollar`	`7.510056919642746` ns/iter	`6.903684821427955` ns/iter	`1.09`
`Regex_Caret_X_Hyphen`	`11.619601562498971` ns/iter	`10.694610714285854` ns/iter	`1.09`
`Regex_Period_Md_Dollar`	`38.042762276787755` ns/iter	`31.700285714286736` ns/iter	`1.20`
`Regex_Caret_Slash_Period_Asterisk`	`11.336453571429063` ns/iter	`10.172175000001005` ns/iter	`1.11`
`Regex_Caret_Period_Range_Dollar`	`9.684230313909739` ns/iter	`8.940262460087324` ns/iter	`1.08`
`Regex_Nested_Backtrack`	`49.541549999992185` ns/iter	`38.716662946423696` ns/iter	`1.28`
`JSON_Array_Of_Objects_Unique`	`484.0489052776873` ns/iter	`393.4849690408606` ns/iter	`1.23`
`JSON_Parse_1`	`8374.70870535714` ns/iter	`6482.516964285066` ns/iter	`1.29`
`JSON_Parse_Real`	`15471.841517855317` ns/iter	`10887.95156250022` ns/iter	`1.42`
`JSON_Parse_Decimal`	`16178.446428570327` ns/iter	`11705.14999999942` ns/iter	`1.38`
`JSON_Parse_Schema_ISO_Language`	`6207239.285713634` ns/iter	`5578945.5357140945` ns/iter	`1.11`
`JSON_Fast_Hash_Helm_Chart_Lock`	`69.74895089284823` ns/iter	`58.275357142859114` ns/iter	`1.20`
`JSON_Equality_Helm_Chart_Lock`	`260.45664285715833` ns/iter	`211.2875106568341` ns/iter	`1.23`
`JSON_Divisible_By_Decimal`	`252.48889285714023` ns/iter	`196.75127693076618` ns/iter	`1.28`
`JSON_String_Equal/10`	`12.87495535714405` ns/iter	`9.249333440851311` ns/iter	`1.39`
`JSON_String_Equal/100`	`13.21955892857066` ns/iter	`9.937745312500468` ns/iter	`1.33`
`JSON_String_Equal_Small_By_Perfect_Hash/10`	`1.8831195552528406` ns/iter	`1.3737057583152106` ns/iter	`1.37`
`JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10`	`12.945951785714069` ns/iter	`8.765679871582506` ns/iter	`1.48`
`JSON_String_Fast_Hash/10`	`3.7722377232141113` ns/iter	`3.285955786383989` ns/iter	`1.15`
`JSON_String_Fast_Hash/100`	`3.7663146361319266` ns/iter	`3.291448130143039` ns/iter	`1.14`
`JSON_String_Key_Hash/10`	`3.772393415178194` ns/iter	`3.3048871926636805` ns/iter	`1.14`
`JSON_String_Key_Hash/100`	`14.393111319672743` ns/iter	`13.183953571427764` ns/iter	`1.09`
`JSON_Object_Defines_Miss_Same_Length`	`3.8495662431261084` ns/iter	`2.9937401785714104` ns/iter	`1.29`
`JSON_Object_Defines_Miss_Too_Small`	`3.7791964218230865` ns/iter	`3.0994727678569842` ns/iter	`1.22`
`JSON_Object_Defines_Miss_Too_Large`	`5.024364999999307` ns/iter	`3.850118564553335` ns/iter	`1.30`
`Pointer_Object_Traverse`	`39.59327642312028` ns/iter	`32.647917697621985` ns/iter	`1.21`
`Pointer_Object_Try_Traverse`	`51.96700999999848` ns/iter	`42.02326303068031` ns/iter	`1.24`
`Pointer_Push_Back_Pointer_To_Weak_Pointer`	`161.68774553571654` ns/iter	`123.59239285714807` ns/iter	`1.31`
`Pointer_Walker_Schema_ISO_Language`	`11699945.312498627` ns/iter	`13160498.214284237` ns/iter	`0.89`
`Pointer_Maybe_Tracked_Deeply_Nested/0`	`1906735.4515050969` ns/iter	`1706452.1739129028` ns/iter	`1.12`
`Pointer_Maybe_Tracked_Deeply_Nested/1`	`3081166.1016947883` ns/iter	`2559718.1818180946` ns/iter	`1.20`
`Pointer_Position_Tracker_Get_Deeply_Nested`	`624.514621140302` ns/iter	`509.69098214283446` ns/iter	`1.23`
`URITemplateRouter_Create`	`40090.70870535528` ns/iter	`29087.18351074924` ns/iter	`1.38`
`URITemplateRouter_Match`	`205.1179662893624` ns/iter	`164.5588839285799` ns/iter	`1.25`
`URITemplateRouter_Match_BasePath`	`237.8155357143084` ns/iter	`192.03891000348875` ns/iter	`1.24`
`URITemplateRouterView_Restore`	`31341.823806718614` ns/iter	`18358.18744321937` ns/iter	`1.71`
`URITemplateRouterView_Match`	`157.67937500000988` ns/iter	`122.66294642858254` ns/iter	`1.29`
`URITemplateRouterView_Match_BasePath`	`180.81207864395984` ns/iter	`141.63391778418335` ns/iter	`1.28`
`URITemplateRouterView_Arguments`	`450.70117838362404` ns/iter	`344.0048537491094` ns/iter	`1.31`
`JSONL_Parse_Large`	`27831212.000000957` ns/iter	`22607681.25000112` ns/iter	`1.23`
`JSONL_Parse_Large_GZIP`	`27468584.000002917` ns/iter	`22180515.624999233` ns/iter	`1.24`
`HTML_Build_Table_100000`	`83972900.00000013` ns/iter	`75887533.3333309` ns/iter	`1.11`
`HTML_Render_Table_100000`	`7752842.22222202` ns/iter	`7266293.33333272` ns/iter	`1.07`
`GZIP_Compress_ISO_Language_Set_3_Locations`	`40805088.235288166` ns/iter	`34080242.857147` ns/iter	`1.20`
`GZIP_Decompress_ISO_Language_Set_3_Locations`	`10564801.562500393` ns/iter	`8790297.333333304` ns/iter	`1.20`
`GZIP_Compress_ISO_Language_Set_3_Schema`	`2313728.093645599` ns/iter	`1954361.7391303522` ns/iter	`1.18`
`GZIP_Decompress_ISO_Language_Set_3_Schema`	`659269.0178570542` ns/iter	`502134.0178571571` ns/iter	`1.31`

This comment was automatically generated by workflow using github-action-benchmark.

Misc improvements to the stacktrace module

83faf64

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

cubic-dev-ai Bot reviewed May 26, 2026

View reviewed changes

Comment thread src/lang/stacktrace/stacktrace_windows.h

augmentcode Bot reviewed May 26, 2026

View reviewed changes

Comment thread src/lang/stacktrace/stacktrace_posix.h

Comment thread src/lang/stacktrace/stacktrace_windows.h Outdated

Simpler

e9a1360

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

jviotti force-pushed the stacktrace-review branch from 6ddaa8c to e9a1360 Compare May 26, 2026 23:55

Simpler

772199f

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

jviotti force-pushed the stacktrace-review branch from ce2969c to 772199f Compare May 27, 2026 00:00

Fix

e0ffa53

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

github-actions Bot reviewed May 27, 2026

View reviewed changes

jviotti merged commit 336d4ad into main May 27, 2026
13 checks passed

jviotti deleted the stacktrace-review branch May 27, 2026 00:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Misc improvements to the `stacktrace` module#2429

Misc improvements to the `stacktrace` module#2429
jviotti merged 4 commits into
mainfrom
stacktrace-review

jviotti commented May 26, 2026

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

augmentcode Bot commented May 26, 2026

Uh oh!

augmentcode Bot left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot left a comment

Uh oh!

github-actions Bot left a comment

Uh oh!

github-actions Bot left a comment

Uh oh!

github-actions Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

jviotti commented May 26, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

augmentcode Bot commented May 26, 2026

Uh oh!

augmentcode Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Benchmark (macos/llvm)

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Benchmark (linux/gcc)

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Benchmark (linux/llvm)

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Benchmark (windows/msvc)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

cubic-dev-ai Bot left a comment •

edited

Loading