Skip to content

[PROJECT] Add simple status and comment txt#48

Open
TheRedDaemon wants to merge 1 commit intomainfrom
project/add-simple-status-and-comment-txt
Open

[PROJECT] Add simple status and comment txt#48
TheRedDaemon wants to merge 1 commit intomainfrom
project/add-simple-status-and-comment-txt

Conversation

@TheRedDaemon
Copy link
Contributor

@TheRedDaemon TheRedDaemon commented Mar 21, 2026

If you have any other ideas (position, content, general other approach), I am very open for them.
I just thought it might be a good idea to keep simple manuel comments and state in a single place.
Diffs will work also, assuming no one does a 10000 lines+ change on the rather big txt.

Now this might clash with potential changes in the address handling:
The txt is completely separate from any automatic process that might "recreate" the address header (unless that is not intended).

So maybe instead of a big "here are all states and comments", maybe a simple "I have a comment to the implementation of this address" txt would be better?
The core idea is just to have stuff like "needed to use optimize("s", on)" attached to its address in one place with an easy to view diff.
@gynt , what do you think?

@TheRedDaemon TheRedDaemon force-pushed the project/add-simple-status-and-comment-txt branch from 920a30d to 80af56b Compare March 21, 2026 23:32
@TheRedDaemon TheRedDaemon requested a review from gynt March 21, 2026 23:39
@TheRedDaemon TheRedDaemon marked this pull request as ready for review March 21, 2026 23:39
@gynt
Copy link
Contributor

gynt commented Mar 23, 2026

I like the general idea.
The address enum may increment (ghidra doesn't export addresses we don't have labelled yet).
Therefore, I would like to see a script (in python, I guess) that can incrementally take in the comments file, add new rows for what is in the addresses.hpp file that wasn't there yet, and then sort the rows by address and write that back out.

namespace Address {
enum {
  SHC_HASH_ADDR
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants