Open
Conversation
920a30d to
80af56b
Compare
Contributor
|
I like the general idea. namespace Address {
enum {
SHC_HASH_ADDR
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have any other ideas (position, content, general other approach), I am very open for them.
I just thought it might be a good idea to keep simple manuel comments and state in a single place.
Diffs will work also, assuming no one does a 10000 lines+ change on the rather big txt.
Now this might clash with potential changes in the address handling:
The txt is completely separate from any automatic process that might "recreate" the address header (unless that is not intended).
So maybe instead of a big "here are all states and comments", maybe a simple "I have a comment to the implementation of this address" txt would be better?
The core idea is just to have stuff like "needed to use
optimize("s", on)" attached to its address in one place with an easy to view diff.@gynt , what do you think?