Conversation
bahrmichael
approved these changes
Mar 9, 2026
keegancsmith
reviewed
Mar 9, 2026
Comment on lines
32
to
+35
| if err := t.refreshToken(ctx); err != nil { | ||
| return nil, err | ||
| } | ||
| token := t.getToken() |
Member
There was a problem hiding this comment.
very minor: you lock in refresh and in getToken, and this is the only place you call both. Maybe instead you can refactor it to read like this
Suggested change
| if err := t.refreshToken(ctx); err != nil { | |
| return nil, err | |
| } | |
| token := t.getToken() | |
| token, err := t.getToken(ctx) | |
| if err != nil { | |
| return nil, err | |
| } |
Contributor
Author
There was a problem hiding this comment.
yeah I tend to agree. It did feel bit 💩 to do it - only thing that stopped me was getToken does more than what it says, although it's minor in the long run.
I'll update it in a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a read race mentioned here by @keegancsmith
Test plan
Unit tests