Conversation
burmudar
commented
Mar 9, 2026
| if !p.useOAuth && (noToken || endpointConflict) { | ||
| fmt.Fprintln(out) | ||
| switch { | ||
| case noToken: |
Contributor
Author
There was a problem hiding this comment.
This branch was moved to login_validate.go-> runMissingAuthLogin
burmudar
commented
Mar 9, 2026
| fmt.Fprintf(p.out, "⚠️ Warning: Configuring src with a JSON file is deprecated. Please migrate to using the env vars SRC_ENDPOINT, SRC_ACCESS_TOKEN, and SRC_PROXY instead, and then remove %s. See https://github.com/sourcegraph/src-cli#readme for more information.\n", p.cfg.ConfigFilePath) | ||
| } | ||
|
|
||
| if p.useOAuth { |
Contributor
Author
There was a problem hiding this comment.
moved to login_oauth.go -> runOAuthDeviceFlow
burmudar
commented
Mar 9, 2026
| endpointArg := cleanEndpoint(p.endpoint) | ||
|
|
||
| // See if the user is already authenticated. | ||
| query := `query CurrentUser { currentUser { username } }` |
Contributor
Author
There was a problem hiding this comment.
moved to login_validate.go -> runValidateLogin
Contributor
Author
|
EDIT: It was against dotCom, and it works against S2 |
keegancsmith
approved these changes
Mar 9, 2026
Member
keegancsmith
left a comment
keegancsmith
left a comment
There was a problem hiding this comment.
nice stuff. Just did loads of testing with --oauth and its working well.
- split login into distinct flows - add specific flow for oauth - add specific flows for error conditions - update tests
burmudar
force-pushed
the
wb/refactor-login-flows
branch
from
eb8f159 to
ec66359
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of CPL-257
Test plan
Unit tests