refactor(api): add buildTransport that uses ProxyTransport#1225
Merged
refactor(api): add buildTransport that uses ProxyTransport#1225
Conversation
- NewProxyTransport creates a cloned transport which does the required proxy handling in dial etc. - Remove use of 'customTransport'
burmudar
force-pushed
the
wb/refactor-apply-proxy
branch
from
774e849 to
fab6e43
Compare
keegancsmith
approved these changes
Dec 5, 2025
Member
keegancsmith
left a comment
keegancsmith
left a comment
There was a problem hiding this comment.
do you have any idea why it took so much care to avoid creating an http.Client? I guess weird code evolution.
Otherwise from what I can tell that is the only functional change this PR does, which is fine. So a refactoring PR right? LGTM
- add doc string - unexport - delete low value tests
Contributor
Author
No idea tbh. I think it was just being a tad overcautious? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The customTransport boolean made it a bit awkward to add new things, especially it you want to just wrap a transport. So here we refactor:
buildTransporthandles all the different configurations to build a transportTest plan
Tested by making Amp write a minimal proxy for unix / http and then running
go run ./cmd/src login. For the socks5 proxy I ranssh -D :5050 mediawhere media is another machine on my network.