Skip to content

fixup pipBulkShow function to prevent breaking with numerous names #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ficapy wants to merge 1 commit into
base: scip
Choose a base branch
from
Open

fixup pipBulkShow function to prevent breaking with numerous names #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/pyright-scip/src/virtualenv/environment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ function pipList(): PipInformation[] {
}

function pipBulkShow(names: string[]): string[] {
// TODO: This probably breaks with enough names. Should batch them into 512 or whatever the max for bash would be
const maxBuffer = 1024 * 1024 * 10; // 10MB
return child_process
.execSync(`${getPipCommand()} show -f ${names.join(' ')}`)
.toString()
.spawnSync(getPipCommand(), ['show', '-f', `${names.join(' ')}`], {maxBuffer})
.stdout.toString()
.split('---');
}

Expand Down