OSS-24153 | Fixed type annotations in assignments not creating symbols #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
varungandhi-src
left a comment
varungandhi-src
left a comment
There was a problem hiding this comment.
I haven't had the time to look into this fully, so could you elaborate on:
- Is this meant as a full fix for the underlying bug?
- Is the 'TODO' meant for yourself or meant to be merged?
Additionally, could you add some tests covering different cases?
Changes the method lookup logic to use the same logic as Pyright internals instead of our own ad-hoc implementation of name resolution, which does not match Python's method resolution order (MRO), which is based purely on names, and not on types. This gets rid of a code path where we were doing a `!` operation, which triggered a crash when indexing a prospect's codebase. Fixes GRAPH-1278.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.