Skip to content

Cast import paths to lowercase #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Titou325 wants to merge 5 commits into
base: scip
Choose a base branch
from
Open

Cast import paths to lowercase #138

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
805a253
#91 - adds reproducible test cases and fixes
Titou325 Nov 8, 2023
514bf16
#91 - adds nested resolution edge case
Titou325 Nov 8, 2023
532c1b0
Casts paths to lowercase to prevent inconsistency on macOS
Titou325 Nov 24, 2023
b2af910
Revert "#91 - adds nested resolution edge case"
Titou325 Nov 24, 2023
e45b593
Revert "#91 - adds reproducible test cases and fixes"
Titou325 Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/pyright-internal/src/analyzer/importResolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1284,6 +1284,13 @@ export class ImportResolver {
filePath: string,
stripTopContainerDir = false
): ModuleNameInfoFromPath | undefined {
/**
* TODO(https://github.com/sourcegraph/scip-python/issues/91)
* Both paths are casted to lowercase to make the comparison case-insensitive. This has been fixed upstream and should be removed on merge.
*/
containerPath = containerPath.toLowerCase();
filePath = filePath.toLowerCase();

containerPath = ensureTrailingDirectorySeparator(containerPath);
let filePathWithoutExtension = stripFileExtension(filePath);

Expand Down