-
-
Notifications
You must be signed in to change notification settings - Fork 38
Add #[mutants::exclude_re("pattern")] attribute #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sandersaares
wants to merge
5
commits into
sourcefrog:main
Choose a base branch
from
sandersaares:exclude-re-attr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
137ec77
Add #[mutants::exclude_re("pattern")] attribute
sandersaares 7cc7410
Use raw string literal in exclude_re doc example
sandersaares b059fd6
Preserve first error in push_exclude_re
sandersaares fd5045e
Fix testdata regexes to match their comments
sandersaares 63b9c32
Add inline comments listing filtered mutations in testdata
sandersaares File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,3 +24,25 @@ use proc_macro::TokenStream; | |
| pub fn skip(_attr: TokenStream, item: TokenStream) -> TokenStream { | ||
| item | ||
| } | ||
|
|
||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We ought to also bump the version of |
||
| /// Exclude specific mutations matching a regex pattern. | ||
| /// | ||
| /// Unlike [macro@skip], which skips all mutations on a function, this attribute allows | ||
| /// you to exclude only mutations whose name matches the given regex, while keeping | ||
| /// other mutations active. | ||
| /// | ||
| /// This can be applied to functions, impl blocks, trait blocks, modules, etc. | ||
| /// | ||
| /// ``` | ||
| /// #[mutants::exclude_re("delete match arm")] | ||
| /// pub fn some_function() -> i32 { | ||
| /// // ... | ||
| /// # 0 | ||
| /// } | ||
| /// ``` | ||
| /// | ||
| /// This is a no-op during compilation, but is seen by cargo-mutants as it processes the source. | ||
| #[proc_macro_attribute] | ||
| pub fn exclude_re(_attr: TokenStream, item: TokenStream) -> TokenStream { | ||
| item | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I thought so too.