Skip to content

fix(web): Support multiple IDPs of the same type#1177

Open
brendan-kellam wants to merge 2 commits intov5from
bkellam/multi-idp
Open

fix(web): Support multiple IDPs of the same type#1177
brendan-kellam wants to merge 2 commits intov5from
bkellam/multi-idp

Conversation

@brendan-kellam
Copy link
Copy Markdown
Contributor

@brendan-kellam brendan-kellam commented May 5, 2026

This PR adds support for multiple IDP providers of the same type. This is mostly useful in the scenario where you have code hosted in e.g., gitlab.com and a self-hosted gitlab instance and you want to use permission syncing. In this scenario, users need a mechanism of linking their account from gitlab.com and the self-hosted gitlab deployment.

Here's a example config:

"identityProviders": {
    "gitlab-self-hosted": {
        "provider": "gitlab",
        "purpose": "account_linking",
        "baseUrl": "https://gitlab.sourcebot.dev",
        "clientId": {
            "env": "GITLAB_SH_CLIENT_ID"
        },
        "clientSecret": {
            "env": "GITLAB_SH_CLIENT_SECRET"
        },
        "displayName": "GitLab Self Hosted"
    },
    "gitlab-dot-com": {
        "provider": "gitlab",
        "purpose": "account_linking",
        "clientId": {
            "env": "GITLAB_DOT_COM_CLIENT_ID"
        },
        "clientSecret": {
            "env": "GITLAB_DOT_COM_CLIENT_SECRET"
        },
        "displayName": "GitLab.com"
    }
}

TODOs:

  • Document the object form of identityProviders
  • Add additional UTs
  • Test back-compat scenario

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 13f8e984-8541-4e71-82da-2fb694d016f1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bkellam/multi-idp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@brendan-kellam brendan-kellam marked this pull request as ready for review May 5, 2026 23:07
@brendan-kellam brendan-kellam changed the title wip: multi-idp support fix(web): Support multiple IDPs of the same type May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant