Upgrade React ecosystem dependencies to v19#3247
Merged
RichDom2185 merged 46 commits intomasterfrom Mar 16, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the frontend to React 19 and adjusts TypeScript + tests/snapshots to match the new React typings and rendering behavior (migrating away from react-test-renderer/shallow rendering toward Testing Library).
Changes:
- Upgraded
react,react-dom,react-konvaand related@types/*; removedreact-test-renderer. - Reworked test utilities and many unit tests to use
@testing-library/reactrendering + updated snapshots. - Tightened typings across the codebase (notably refs and JSX-related typing imports) to satisfy updated React/TS types.
Reviewed changes
Copilot reviewed 96 out of 97 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Dependency lock updates for React 19/tooling |
| package.json | React 19 + types bumps; remove react-test-renderer |
| src/pages/sicp/subcomponents/SicpExercise.tsx | JSX typing import adjustment |
| src/pages/sicp/subcomponents/chatbot/ChatBox.tsx | Ref type updated to allow null |
| src/pages/sicp/subcomponents/tests/SicpLatex.test.tsx | Switch to renderTree snapshots |
| src/pages/sicp/subcomponents/tests/CodeSnippet.test.tsx | Switch to Testing Library render + snapshots |
| src/pages/sicp/subcomponents/tests/snapshots/SicpToc.test.tsx.snap | Snapshot updated for DOM fragment output |
| src/pages/sicp/subcomponents/tests/snapshots/SicpLatex.test.tsx.snap | Snapshot updated for DOM fragment output |
| src/pages/sicp/subcomponents/tests/snapshots/SicpExercise.test.tsx.snap | Snapshot updated for DOM fragment output |
| src/pages/sicp/subcomponents/tests/snapshots/CodeSnippet.test.tsx.snap | Snapshot updated for DOM fragment output |
| src/pages/sicp/Sicp.tsx | Ref callback formatting (block body) |
| src/pages/sicp/tests/Sicp.test.tsx | Switch to renderTree snapshots |
| src/pages/sicp/tests/snapshots/Sicp.test.tsx.snap | Snapshot updated for DOM fragment output |
| src/pages/playground/tests/snapshots/Playground.test.tsx.snap | Snapshot updated (aria attribute changes) |
| src/pages/githubCallback/tests/GitHubCallback.test.tsx | JSX typing import adjustment |
| src/pages/academy/gameSimulator/subcomponents/assetViewer/AssetViewerUtils.tsx | JSX type import added |
| src/pages/academy/gameSimulator/subcomponents/assetViewer/AssetViewer.tsx | JSX typing import adjustment |
| src/pages/academy/adminPanel/subcomponents/userConfigPanel/UserConfigPanel.tsx | Ref initialization + optional chaining export |
| src/pages/academy/adminPanel/subcomponents/storiesUserConfigPanel/StoriesUserConfigPanel.tsx | Ref initialization + optional chaining export |
| src/pages/academy/adminPanel/subcomponents/assessmentConfigPanel/AssessmentConfigPanel.tsx | Grid API ref init updated |
| src/pages/academy/adminPanel/subcomponents/AddUserPanel.tsx | JSX typing import adjustment |
| src/pages/academy/adminPanel/subcomponents/AddStoriesUserPanel.tsx | JSX typing import adjustment |
| src/features/sicp/parser/ParseJson.tsx | JSX typing import + ref callback formatting |
| src/features/sicp/errors/SicpErrors.tsx | JSX type import added |
| src/features/sicp/errors/tests/SicpErrors.test.tsx | Switch to renderTree snapshots + assertions |
| src/features/sicp/errors/tests/snapshots/SicpErrors.test.tsx.snap | Snapshot updated for DOM fragment output |
| src/features/dataVisualizer/tree/Tree.tsx | JSX type import added |
| src/features/dataVisualizer/tree/FunctionTreeNode.tsx | JSX type import added |
| src/features/dataVisualizer/tree/DrawableTreeNode.tsx | JSX type import added |
| src/features/dataVisualizer/tree/ArrayTreeNode.tsx | JSX type import added |
| src/features/dataVisualizer/dataVisualizerTypes.ts | JSX type import added |
| src/features/dataVisualizer/dataVisualizer.tsx | JSX type import added |
| src/features/cseMachine/CseMachineLayout.tsx | RefObject types updated to include null |
| src/features/cseMachine/components/values/GlobalFnValue.tsx | Konva Label ref types updated to include null |
| src/features/cseMachine/components/values/FnValue.tsx | Konva Label ref types updated to include null |
| src/features/cseMachine/components/values/ContValue.tsx | Konva Label ref types updated to include null |
| src/features/cseMachine/components/Text.tsx | Konva Label ref types updated to include null |
| src/features/cseMachine/components/arrows/GenericArrow.tsx | Konva refs updated to include null |
| src/features/cseMachine/tests/snapshots/CseMachineAnimation.test.tsx.snap | Snapshot updated (ref output) |
| src/features/cseMachine/tests/snapshots/CseMachine.test.tsx.snap | Snapshot updated (ref output) |
| src/commons/utils/TestUtils.ts | Replace shallow renderer with Testing Library helpers |
| src/commons/utils/notifications/NotificationsHelper.ts | JSX type import added |
| src/commons/utils/Hooks.ts | RefObject param updated to include null |
| src/commons/utils/CopyToClipboard.tsx | Relax typing around cloneElement/child props |
| src/commons/utils/tests/TestUtils.test.tsx | Remove shallowRender test; keep deepFilter tests |
| src/commons/sourceRecorder/SourceRecorderEditor.tsx | RefObject type updated to include null |
| src/commons/sourceRecorder/SourceRecorderControlBar.tsx | RefObject type updated to include null |
| src/commons/sideContent/SideContentTypes.ts | JSX type import added |
| src/commons/sideContent/SideContentProvider.tsx | JSX type import added |
| src/commons/sideContent/SideContent.tsx | JSX type import added |
| src/commons/sideContent/content/SideContentContestVoting.tsx | Ref callback formatting (block body) |
| src/commons/sideContent/content/githubAssessments/SideContentMarkdownEditor.tsx | Add typed node ref |
| src/commons/sideContent/tests/SideContentContestLeaderboard.test.tsx | Switch to Testing Library snapshots |
| src/commons/sideContent/tests/SideContentAutograder.test.tsx | Switch to Testing Library snapshots + queries |
| src/commons/sideContent/tests/snapshots/SideContentHtmlDisplay.test.tsx.snap | Snapshot updated for DOM fragment output |
| src/commons/sideContent/tests/snapshots/SideContentContestVoting.test.tsx.snap | Snapshot updated for DOM fragment output |
| src/commons/sideContent/tests/snapshots/SideContentContestLeaderboard.test.tsx.snap | Snapshot updated for DOM fragment output |
| src/commons/sideBar/SideBar.tsx | JSX typing import adjustment |
| src/commons/repl/ReplInput.tsx | JSX typing import adjustment |
| src/commons/repl/Repl.tsx | JSX typing import adjustment |
| src/commons/repl/tests/Repl.test.tsx | Reworked snapshots (currently not rendering) |
| src/commons/repl/tests/snapshots/Repl.test.tsx.snap | Snapshot content changed to element props/DOM output |
| src/commons/profile/Profile.tsx | Use satisfies React.FC + JSX typing import |
| src/commons/navigationBar/subcomponents/tests/SicpNavigationBar.test.tsx | Switch to Testing Library + router wrapper |
| src/commons/navigationBar/subcomponents/tests/AcademyNavigationBar.test.tsx | Switch to Testing Library + real store/router |
| src/commons/navigationBar/subcomponents/tests/snapshots/SicpNavigationBar.test.tsx.snap | Snapshot updated for DOM fragment output |
| src/commons/navigationBar/subcomponents/tests/snapshots/NavigationBarLangSelectButton.test.tsx.snap | Snapshot updated for DOM fragment output |
| src/commons/navigationBar/tests/NavigationBar.test.tsx | Switch to Testing Library + store/router context |
| src/commons/mobileWorkspace/mobileSideContent/MobileSideContent.tsx | JSX typing import adjustment |
| src/commons/fileSystemView/FileSystemViewContextMenu.tsx | JSX typing import adjustment |
| src/commons/editor/tests/Editor.test.tsx | Render with Provider + renderTree snapshots |
| src/commons/editor/tests/snapshots/Editor.test.tsx.snap | Snapshot updated for DOM fragment output |
| src/commons/dropdown/DropdownCreateCourse.tsx | Use satisfies React.FC |
| src/commons/dropdown/DropdownCourses.tsx | Use satisfies React.FC |
| src/commons/dropdown/tests/Dropdown.test.tsx | Remove react-test-renderer structure asserts; snapshot only |
| src/commons/dropdown/tests/snapshots/Dropdown.test.tsx.snap | Snapshot updated for DOM fragment output |
| src/commons/delay/Delay.tsx | JSX typing import adjustment |
| src/commons/controlBar/ControlBarShareButton.tsx | RefObject type updated to include null |
| src/commons/controlBar/ControlBar.tsx | JSX typing import adjustment |
| src/commons/ContentDisplay.tsx | JSX typing import adjustment |
| src/commons/assessmentWorkspace/tests/AssessmentWorkspace.test.tsx | Switch snapshot to Testing Library fragment |
| src/commons/assessmentWorkspace/tests/snapshots/AssessmentWorkspace.test.tsx.snap | Snapshot updated (aria attr changes) |
| src/commons/assessment/Assessment.tsx | JSX typing import adjustment |
| src/commons/assessment/tests/Assessment.test.tsx | Prefer findBy* async queries over manual act |
| src/commons/application/tests/Application.test.tsx | Switch to Testing Library + store/router |
| src/commons/application/tests/snapshots/Application.test.tsx.snap | Snapshot updated for DOM fragment output |
| src/commons/achievement/control/GoalEditor.tsx | JSX typing import adjustment |
| src/commons/achievement/control/AchievementEditor.tsx | JSX typing import adjustment |
| src/commons/tests/snapshots/Markdown.test.tsx.snap | Snapshot updated for DOM fragment output |
| src/commons/tests/snapshots/ContentDisplay.test.tsx.snap | Snapshot updated for DOM fragment output |
Comments suppressed due to low confidence (3)
src/pages/academy/adminPanel/subcomponents/userConfigPanel/UserConfigPanel.tsx:66
React.useRef<GridApi>(null)will typically pick theRefObjectoverload (wherecurrentcan be treated as read-only), butonGridReadyassigns togridApi.current. To keepcurrentsafely mutable after the React/@types upgrade, preferReact.useRef<GridApi | null>(null)(or revert toReact.useRef<GridApi>()+ optional chaining).
src/pages/academy/adminPanel/subcomponents/storiesUserConfigPanel/StoriesUserConfigPanel.tsx:65React.useRef<GridApi>(null)can resolve to theRefObjectoverload (wherecurrentmay be treated as read-only), butonGridReadyassignsgridApi.current = params.api. UseReact.useRef<GridApi | null>(null)(mutable) or keep the previoususeRef<GridApi>()pattern to avoid TS errors.
src/pages/academy/adminPanel/subcomponents/assessmentConfigPanel/AssessmentConfigPanel.tsx:100React.useRef<GridApi<AssessmentConfiguration>>(null)may pick theRefObjectoverload (wherecurrentmay be treated as read-only), but this ref is mutated in multiple places (gridApi.current?...). Make it explicitly mutable by usingReact.useRef<GridApi<AssessmentConfiguration> | null>(null)(or initialize withundefined).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@sentry review this |
Pull Request Test Coverage Report for Build 23145267133Details
💛 - Coveralls |
Contributor
|
@coderabbitai review this PR |
|
✅ Actions performedReview triggered.
|
WalkthroughThis pull request modernizes the codebase by upgrading React to v19, replacing drag-and-drop libraries from react-sortable-hoc to Changes
Sequence Diagram(s)sequenceDiagram
participant User as User
participant UI as React Component
participant DndKit as DnD Kit (DndContext)
participant Handler as onSortEnd Handler
participant State as State Management
User->>UI: Drag SortableItem
UI->>DndKit: DragStart Event
DndKit->>DndKit: Track active/over items
User->>UI: Drop SortableItem
UI->>DndKit: DragEnd Event (DragEndEvent)
DndKit->>Handler: Emit DragEndEvent with active/over
Handler->>Handler: Calculate oldIndex/newIndex via arrayMove
Handler->>State: Update items array
State->>UI: Re-render with new order
UI->>User: Display reordered list
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can suggest fixes for GitHub Check annotations.Configure the |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
src/commons/achievement/control/AchievementEditor.tsx (2)
31-37:⚠️ Potential issue | 🔴 CriticalBounds check order causes potential crash when UUID not found.
If
uuiddoesn't exist ineditableCards, the loop incrementsidxuntilidx === editableCards.length. On the next condition evaluation,editableCards[idx].keyaccesses an undefined element before the bounds check, causing a runtime error.🐛 Proposed fix: swap condition order
const removeCard = (uuid: string) => { let idx = 0; - while (editableCards[idx].key !== uuid && idx < editableCards.length) { + while (idx < editableCards.length && editableCards[idx].key !== uuid) { idx++; } + if (idx >= editableCards.length) { + return; // UUID not found + } editableCards.splice(idx, 1); };🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/commons/achievement/control/AchievementEditor.tsx` around lines 31 - 37, The removeCard function can access editableCards[idx] out of bounds if the uuid isn't found; update removeCard to check the index bound before accessing element (i.e., test idx < editableCards.length first in the while condition) or replace the loop with a safe lookup such as Array.prototype.findIndex to get the target index and only splice if index !== -1; reference the removeCard function and the editableCards array when making the change.
7-7:⚠️ Potential issue | 🟠 MajorModule-level mutable state will cause stale data across mounts.
editableCardspersists outside the component lifecycle. IfAchievementEditorunmounts and remounts (e.g., navigation), the array retains stale entries from the previous mount instead of reinitializing from the inferencer. This also breaks React Strict Mode's double-render checks.Consider moving this into component state with
useStateoruseRef.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/commons/achievement/control/AchievementEditor.tsx` at line 7, The module-level mutable array editableCards causes stale cross-mount state in the AchievementEditor component; move editableCards into the component lifecycle (e.g., replace the top-level let editableCards with a useState or useRef inside the AchievementEditor function) and initialize it from the inferencer there, update all places that push/pop or read editableCards to use the state/ref (and corresponding setters) so the array is recreated on each mount and React Strict Mode double-renders behave correctly.src/commons/dropdown/__tests__/Dropdown.test.tsx (1)
40-50:⚠️ Potential issue | 🟠 MajorRestore the assertions these tests are named after.
Both cases now stop at a snapshot and leave the auth-specific check as TODO, so they no longer prove the logged-in/logged-out mounting behavior they describe.
src/commons/dropdown/Dropdown.tsx:42-91still gatesProfile,DropdownCourses, andDropdownCreateCourseonisLoggedIn, and a regression there would now slip through without a targeted assertion.If helpful, I can sketch an RTL-friendly assertion pattern for these logged-in and logged-out cases.
Also applies to: 52-63
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/commons/dropdown/__tests__/Dropdown.test.tsx` around lines 40 - 50, The test currently only snapshots the rendered tree but doesn't assert the auth-specific behavior; update the test "Dropdown does not mount Profile, DropdownCourses and DropdownCreateCourses components when a user is not logged in" (and the similar test at 52-63) to explicitly assert that Profile, DropdownCourses and DropdownCreateCourse are NOT mounted by checking the rendered output from renderTreeJson(getElement(mockStore)) does not contain those component nodes/identifiers (e.g., verify absence of "Profile", "DropdownCourses", "DropdownCreateCourse" in the tree or use the same query helpers you use elsewhere), using the same mockStore and getElement/renderTreeJson setup so the snapshot plus negative assertions prove the logged-out behavior.
🧹 Nitpick comments (6)
src/commons/utils/CopyToClipboard.tsx (1)
25-33: Type safety bypassed withas anycasts.The
as anycasts on lines 25 and 33 work around React 19's strictercloneElementtyping. While functional, this completely bypasses type checking for the children's props.This is acceptable as a pragmatic workaround given the component's purpose (wrapping arbitrary children to inject onClick), but consider documenting why the casts are necessary, e.g., via a brief comment.
💡 Suggested documentation
// Get original onClick handler if any + // Note: Using 'as any' because React 19's stricter cloneElement typing + // doesn't easily support injecting props into arbitrary ReactElement children. const originalOnClick = (children?.props as any)?.onClick;🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/commons/utils/CopyToClipboard.tsx` around lines 25 - 33, The casts to `as any` in CopyToClipboard.tsx (used when accessing (children?.props as any)?.onClick and when passing children into cloneElement) bypass React 19 typings; add a concise comment above the casted usages explaining that these casts are intentional to support wrapping arbitrary children and injecting an onClick handler while React's stricter cloneElement types prevent a safer generic; reference the relevant symbols in the comment (originalOnClick, handleClick, cloneElement, children) and mention this is a pragmatic, documented workaround rather than removing the casts.src/commons/navigationBar/__tests__/NavigationBar.test.tsx (1)
36-57: Consider adding missing session fields for more complete test coverage.The mock store provides
role,name,courseId,courseShortName, andassessmentConfigurations, butNavigationBaralso usesenableAchievements,enableSourcecast,enableStories,enableOverallLeaderboard, andenableContestLeaderboardfrom the session. While these will default to falsy values (disabling those nav items), explicitly setting them would make the test data more complete and the test's intent clearer.💡 Suggested enhancement
const store = mockInitialStore({ session: { role: Role.Student, name: 'Bob', courseId: 1, courseShortName: 'CS1101S', + enableAchievements: true, + enableSourcecast: true, assessmentConfigurations: [🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/commons/navigationBar/__tests__/NavigationBar.test.tsx` around lines 36 - 57, The test's mock store created via mockInitialStore is missing explicit session feature flags used by NavigationBar (enableAchievements, enableSourcecast, enableStories, enableOverallLeaderboard, enableContestLeaderboard); update the session object passed into mockInitialStore to include those boolean fields (true or false as appropriate for the test scenario) so the NavigationBar test covers the presence/absence of those nav items and makes intent explicit.src/commons/utils/TestUtils.ts (2)
4-8: Questionableact()usage — consider simplifying.Line 6
await act(() => app)doesn't perform any state updates; it simply returns the render result from the callback. Theact()wrapper is designed for code that triggers React state changes, not for wrapping already-returned values.If the intent is to wait for effects to settle, consider:
♻️ Suggested fix
export const renderTree = async (element: React.ReactElement) => { - const app = render(element); - await act(() => app); - return app.asFragment(); + let app: ReturnType<typeof render>; + await act(async () => { + app = render(element); + }); + return app!.asFragment(); };Or if synchronous rendering is sufficient:
-export const renderTree = async (element: React.ReactElement) => { - const app = render(element); - await act(() => app); - return app.asFragment(); -}; +export const renderTree = (element: React.ReactElement) => { + const { asFragment } = render(element); + return asFragment(); +};🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/commons/utils/TestUtils.ts` around lines 4 - 8, The current renderTree helper incorrectly wraps the already-returned render() result in await act(() => app); remove the act wrapper and either return render(element).asFragment() directly (for synchronous renders) or, if you need to wait for effects, await a proper async helper such as waitFor(() => {/* assertion */}) or await act(async () => {/* trigger async updates */}); update the renderTree function (referencing renderTree, render, act, and asFragment) to use one of these approaches so act is only used around actual state-updating code or awaitable effects.
10-14: Follow up on the TODO to removerenderTreeJson.The function now just returns
renderTree(element)directly, making it redundant. Consider tracking this cleanup task.Would you like me to open an issue to track the removal of
renderTreeJsonand update all call sites to userenderTreedirectly?🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/commons/utils/TestUtils.ts` around lines 10 - 14, The exported helper renderTreeJson in TestUtils.ts is redundant because it simply awaits and returns renderTree(element); remove the renderTreeJson function and replace all its call sites to call renderTree(...) directly (update imports if they reference renderTreeJson and ensure tests import renderTree from the same module); optionally open a small cleanup PR or issue to track removing renderTreeJson and verifying tests pass after updating call sites.src/commons/assessmentWorkspace/__tests__/AssessmentWorkspace.test.tsx (1)
99-103: Sameact()concern as in TestUtils.ts.The
await act(() => app)pattern here has the same issue —appis already the render result, so wrapping it inact()doesn't trigger any state updates. Consider the same fix suggested for TestUtils.ts.♻️ Suggested fix
const renderElement = async (props: AssessmentWorkspaceProps) => { - const app = render(createMemoryRouterWithRoutes(props)); - await act(() => app); - return app; + let app: ReturnType<typeof render>; + await act(async () => { + app = render(createMemoryRouterWithRoutes(props)); + }); + return app!; };🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/commons/assessmentWorkspace/__tests__/AssessmentWorkspace.test.tsx` around lines 99 - 103, The test's renderElement function misuses act by awaiting act(() => app) where app is the already-completed render result; remove the erroneous await act call and simply return the rendered result from renderElement (i.e., keep the render(createMemoryRouterWithRoutes(props)) call and delete the await act(() => app) line) so that renderElement returns the proper render result from render/createMemoryRouterWithRoutes without wrapping a no-op in act.src/commons/repl/__tests__/Repl.test.tsx (1)
37-37: Remove unnecessaryasyncdeclarations from snapshot tests.These eight snapshot tests declare
asyncbut don't useawait, making the keyword unnecessary noise:
- Line 37:
'Repl renders correctly'- Line 55:
'Code output renders correctly'- Line 60:
'Running output renders correctly'- Line 65:
'Result output (no consoleLogs) renders correctly'- Line 70:
'Result output (with consoleLogs) renders correctly'- Line 79:
'Error output (no consoleLogs) renders correctly'- Line 84:
'Error output (with consoleLogs) renders correctly'- Line 93:
'Empty output renders an empty card'✂️ Suggested diff
-test('Repl renders correctly', async () => { +test('Repl renders correctly', () => { @@ -test('Code output renders correctly', async () => { +test('Code output renders correctly', () => { @@ -test('Running output renders correctly', async () => { +test('Running output renders correctly', () => { @@ -test('Result output (no consoleLogs) renders correctly', async () => { +test('Result output (no consoleLogs) renders correctly', () => { @@ -test('Result output (with consoleLogs) renders correctly', async () => { +test('Result output (with consoleLogs) renders correctly', () => { @@ -test('Error output (no consoleLogs) renders correctly', async () => { +test('Error output (no consoleLogs) renders correctly', () => { @@ -test('Error output (with consoleLogs) renders correctly', async () => { +test('Error output (with consoleLogs) renders correctly', () => { @@ -test('Empty output renders an empty card', async () => { +test('Empty output renders an empty card', () => {🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/commons/repl/__tests__/Repl.test.tsx` at line 37, The listed snapshot tests declare the async keyword but never use await; remove the unnecessary async from each test declaration (e.g., the test blocks named 'Repl renders correctly', 'Code output renders correctly', 'Running output renders correctly', 'Result output (no consoleLogs) renders correctly', 'Result output (with consoleLogs) renders correctly', 'Error output (no consoleLogs) renders correctly', 'Error output (with consoleLogs) renders correctly', and 'Empty output renders an empty card') by changing their signatures to plain synchronous test callbacks and confirming there are no await usages inside those functions (update the test() declarations for those names accordingly).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Around line 39-40: Add `@dnd-kit/utilities` as a direct dependency in
package.json so the import of CSS in src/commons/utils/SortableList.tsx (the
line importing CSS from "@dnd-kit/utilities") resolves without relying on
transitive hoisting; update package.json dependencies to include
"@dnd-kit/utilities" (choose a version compatible with the installed
"@dnd-kit/core" and "@dnd-kit/sortable", e.g., align major version) and run your
package manager install to update lockfiles.
In `@src/commons/sideContent/SideContentTypes.ts`:
- Line 2: The code uses React.MouseEvent<HTMLElement> (e.g.,
React.MouseEvent<HTMLElement>) but the file only imports JSX as a type; add a
type-only import for React to bring the React namespace into scope by adding
"import type React from 'react';" (so references to
React.MouseEvent<HTMLElement> resolve) or alternatively replace usages of
React.MouseEvent with an imported MouseEvent type via "import type { MouseEvent
} from 'react';" and update occurrences (e.g., change
React.MouseEvent<HTMLElement> to MouseEvent<HTMLElement>).
In `@src/commons/utils/SortableList.tsx`:
- Around line 21-23: The code currently uses the item label string as the
dnd-kit id and then calls indexOf(label) to compute reorder indices, which
breaks for duplicate labels and can return -1; change the items to carry a
stable unique id (e.g. add an "id: string" field to the SortableItemProps and
use that id for the draggable id), use findIndex(item => item.id === activeId)
or map to ids to compute from/to indices instead of indexOf(label), and guard
before calling arrayMove (ensure both from and to are >= 0 and different);
update any references in the SortableList/SortableItem components and the
onSortEnd handler to use the new item.id rather than the label.
In `@src/features/sicp/errors/__tests__/SicpErrors.test.tsx`:
- Around line 19-23: Rename the test's description to correctly reflect it's
testing the parsing error: update the test labeled 'unexpected error renders
correctly' to something like 'parsing error renders correctly' in the test that
calls getSicpError(SicpErrorType.PARSING_ERROR) and asserts renderTree(element)
and screen.getByTestId('sicp-parsing-error'); ensure the test name change is
applied where the test function and its description string are defined.
---
Outside diff comments:
In `@src/commons/achievement/control/AchievementEditor.tsx`:
- Around line 31-37: The removeCard function can access editableCards[idx] out
of bounds if the uuid isn't found; update removeCard to check the index bound
before accessing element (i.e., test idx < editableCards.length first in the
while condition) or replace the loop with a safe lookup such as
Array.prototype.findIndex to get the target index and only splice if index !==
-1; reference the removeCard function and the editableCards array when making
the change.
- Line 7: The module-level mutable array editableCards causes stale cross-mount
state in the AchievementEditor component; move editableCards into the component
lifecycle (e.g., replace the top-level let editableCards with a useState or
useRef inside the AchievementEditor function) and initialize it from the
inferencer there, update all places that push/pop or read editableCards to use
the state/ref (and corresponding setters) so the array is recreated on each
mount and React Strict Mode double-renders behave correctly.
In `@src/commons/dropdown/__tests__/Dropdown.test.tsx`:
- Around line 40-50: The test currently only snapshots the rendered tree but
doesn't assert the auth-specific behavior; update the test "Dropdown does not
mount Profile, DropdownCourses and DropdownCreateCourses components when a user
is not logged in" (and the similar test at 52-63) to explicitly assert that
Profile, DropdownCourses and DropdownCreateCourse are NOT mounted by checking
the rendered output from renderTreeJson(getElement(mockStore)) does not contain
those component nodes/identifiers (e.g., verify absence of "Profile",
"DropdownCourses", "DropdownCreateCourse" in the tree or use the same query
helpers you use elsewhere), using the same mockStore and
getElement/renderTreeJson setup so the snapshot plus negative assertions prove
the logged-out behavior.
---
Nitpick comments:
In `@src/commons/assessmentWorkspace/__tests__/AssessmentWorkspace.test.tsx`:
- Around line 99-103: The test's renderElement function misuses act by awaiting
act(() => app) where app is the already-completed render result; remove the
erroneous await act call and simply return the rendered result from
renderElement (i.e., keep the render(createMemoryRouterWithRoutes(props)) call
and delete the await act(() => app) line) so that renderElement returns the
proper render result from render/createMemoryRouterWithRoutes without wrapping a
no-op in act.
In `@src/commons/navigationBar/__tests__/NavigationBar.test.tsx`:
- Around line 36-57: The test's mock store created via mockInitialStore is
missing explicit session feature flags used by NavigationBar
(enableAchievements, enableSourcecast, enableStories, enableOverallLeaderboard,
enableContestLeaderboard); update the session object passed into
mockInitialStore to include those boolean fields (true or false as appropriate
for the test scenario) so the NavigationBar test covers the presence/absence of
those nav items and makes intent explicit.
In `@src/commons/repl/__tests__/Repl.test.tsx`:
- Line 37: The listed snapshot tests declare the async keyword but never use
await; remove the unnecessary async from each test declaration (e.g., the test
blocks named 'Repl renders correctly', 'Code output renders correctly', 'Running
output renders correctly', 'Result output (no consoleLogs) renders correctly',
'Result output (with consoleLogs) renders correctly', 'Error output (no
consoleLogs) renders correctly', 'Error output (with consoleLogs) renders
correctly', and 'Empty output renders an empty card') by changing their
signatures to plain synchronous test callbacks and confirming there are no await
usages inside those functions (update the test() declarations for those names
accordingly).
In `@src/commons/utils/CopyToClipboard.tsx`:
- Around line 25-33: The casts to `as any` in CopyToClipboard.tsx (used when
accessing (children?.props as any)?.onClick and when passing children into
cloneElement) bypass React 19 typings; add a concise comment above the casted
usages explaining that these casts are intentional to support wrapping arbitrary
children and injecting an onClick handler while React's stricter cloneElement
types prevent a safer generic; reference the relevant symbols in the comment
(originalOnClick, handleClick, cloneElement, children) and mention this is a
pragmatic, documented workaround rather than removing the casts.
In `@src/commons/utils/TestUtils.ts`:
- Around line 4-8: The current renderTree helper incorrectly wraps the
already-returned render() result in await act(() => app); remove the act wrapper
and either return render(element).asFragment() directly (for synchronous
renders) or, if you need to wait for effects, await a proper async helper such
as waitFor(() => {/* assertion */}) or await act(async () => {/* trigger async
updates */}); update the renderTree function (referencing renderTree, render,
act, and asFragment) to use one of these approaches so act is only used around
actual state-updating code or awaitable effects.
- Around line 10-14: The exported helper renderTreeJson in TestUtils.ts is
redundant because it simply awaits and returns renderTree(element); remove the
renderTreeJson function and replace all its call sites to call renderTree(...)
directly (update imports if they reference renderTreeJson and ensure tests
import renderTree from the same module); optionally open a small cleanup PR or
issue to track removing renderTreeJson and verifying tests pass after updating
call sites.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1530b397-7cf1-41f2-96ed-582ff65e7733
⛔ Files ignored due to path filters (29)
src/commons/__tests__/__snapshots__/ContentDisplay.test.tsx.snapis excluded by!**/*.snapsrc/commons/__tests__/__snapshots__/Markdown.test.tsx.snapis excluded by!**/*.snapsrc/commons/application/__tests__/__snapshots__/Application.test.tsx.snapis excluded by!**/*.snapsrc/commons/assessment/__tests__/__snapshots__/Assessment.test.tsx.snapis excluded by!**/*.snapsrc/commons/assessmentWorkspace/__tests__/__snapshots__/AssessmentWorkspace.test.tsx.snapis excluded by!**/*.snapsrc/commons/dropdown/__tests__/__snapshots__/Dropdown.test.tsx.snapis excluded by!**/*.snapsrc/commons/editor/__tests__/__snapshots__/Editor.test.tsx.snapis excluded by!**/*.snapsrc/commons/navigationBar/__tests__/__snapshots__/NavigationBar.test.tsx.snapis excluded by!**/*.snapsrc/commons/navigationBar/subcomponents/__tests__/__snapshots__/AcademyNavigationBar.test.tsx.snapis excluded by!**/*.snapsrc/commons/navigationBar/subcomponents/__tests__/__snapshots__/NavigationBarLangSelectButton.test.tsx.snapis excluded by!**/*.snapsrc/commons/navigationBar/subcomponents/__tests__/__snapshots__/SicpNavigationBar.test.tsx.snapis excluded by!**/*.snapsrc/commons/repl/__tests__/__snapshots__/Repl.test.tsx.snapis excluded by!**/*.snapsrc/commons/sideContent/__tests__/__snapshots__/SideContentAutograder.test.tsx.snapis excluded by!**/*.snapsrc/commons/sideContent/__tests__/__snapshots__/SideContentContestLeaderboard.test.tsx.snapis excluded by!**/*.snapsrc/commons/sideContent/__tests__/__snapshots__/SideContentContestVoting.test.tsx.snapis excluded by!**/*.snapsrc/commons/sideContent/__tests__/__snapshots__/SideContentCseMachine.test.tsx.snapis excluded by!**/*.snapsrc/commons/sideContent/__tests__/__snapshots__/SideContentHtmlDisplay.test.tsx.snapis excluded by!**/*.snapsrc/features/cseMachine/__tests__/__snapshots__/CseMachine.test.tsx.snapis excluded by!**/*.snapsrc/features/cseMachine/__tests__/__snapshots__/CseMachineAnimation.test.tsx.snapis excluded by!**/*.snapsrc/features/sicp/errors/__tests__/__snapshots__/SicpErrors.test.tsx.snapis excluded by!**/*.snapsrc/features/sicp/parser/__tests__/__snapshots__/ParseJson.test.tsx.snapis excluded by!**/*.snapsrc/pages/playground/__tests__/__snapshots__/Playground.test.tsx.snapis excluded by!**/*.snapsrc/pages/sicp/__tests__/__snapshots__/Sicp.test.tsx.snapis excluded by!**/*.snapsrc/pages/sicp/subcomponents/__tests__/__snapshots__/CodeSnippet.test.tsx.snapis excluded by!**/*.snapsrc/pages/sicp/subcomponents/__tests__/__snapshots__/SicpExercise.test.tsx.snapis excluded by!**/*.snapsrc/pages/sicp/subcomponents/__tests__/__snapshots__/SicpIndexPage.test.tsx.snapis excluded by!**/*.snapsrc/pages/sicp/subcomponents/__tests__/__snapshots__/SicpLatex.test.tsx.snapis excluded by!**/*.snapsrc/pages/sicp/subcomponents/__tests__/__snapshots__/SicpToc.test.tsx.snapis excluded by!**/*.snapyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (69)
package.jsonsrc/commons/ContentDisplay.tsxsrc/commons/achievement/control/AchievementEditor.tsxsrc/commons/achievement/control/GoalEditor.tsxsrc/commons/application/__tests__/Application.test.tsxsrc/commons/assessment/Assessment.tsxsrc/commons/assessment/__tests__/Assessment.test.tsxsrc/commons/assessmentWorkspace/__tests__/AssessmentWorkspace.test.tsxsrc/commons/controlBar/ControlBar.tsxsrc/commons/controlBar/ControlBarShareButton.tsxsrc/commons/delay/Delay.tsxsrc/commons/dropdown/DropdownCourses.tsxsrc/commons/dropdown/DropdownCreateCourse.tsxsrc/commons/dropdown/__tests__/Dropdown.test.tsxsrc/commons/editor/__tests__/Editor.test.tsxsrc/commons/fileSystemView/FileSystemViewContextMenu.tsxsrc/commons/mobileWorkspace/mobileSideContent/MobileSideContent.tsxsrc/commons/navigationBar/__tests__/NavigationBar.test.tsxsrc/commons/navigationBar/subcomponents/__tests__/AcademyNavigationBar.test.tsxsrc/commons/navigationBar/subcomponents/__tests__/SicpNavigationBar.test.tsxsrc/commons/profile/Profile.tsxsrc/commons/repl/Repl.tsxsrc/commons/repl/ReplInput.tsxsrc/commons/repl/__tests__/Repl.test.tsxsrc/commons/sideBar/SideBar.tsxsrc/commons/sideContent/SideContent.tsxsrc/commons/sideContent/SideContentProvider.tsxsrc/commons/sideContent/SideContentTypes.tssrc/commons/sideContent/__tests__/SideContentAutograder.test.tsxsrc/commons/sideContent/__tests__/SideContentContestLeaderboard.test.tsxsrc/commons/sideContent/content/SideContentContestVoting.tsxsrc/commons/sideContent/content/githubAssessments/SideContentMarkdownEditor.tsxsrc/commons/sourceRecorder/SourceRecorderControlBar.tsxsrc/commons/sourceRecorder/SourceRecorderEditor.tsxsrc/commons/utils/CopyToClipboard.tsxsrc/commons/utils/Hooks.tssrc/commons/utils/SortableList.tsxsrc/commons/utils/TestUtils.tssrc/commons/utils/__tests__/TestUtils.test.tsxsrc/commons/utils/notifications/NotificationsHelper.tssrc/features/cseMachine/CseMachineLayout.tsxsrc/features/cseMachine/components/Text.tsxsrc/features/cseMachine/components/arrows/GenericArrow.tsxsrc/features/cseMachine/components/values/ContValue.tsxsrc/features/cseMachine/components/values/FnValue.tsxsrc/features/cseMachine/components/values/GlobalFnValue.tsxsrc/features/dataVisualizer/dataVisualizer.tsxsrc/features/dataVisualizer/dataVisualizerTypes.tssrc/features/dataVisualizer/tree/ArrayTreeNode.tsxsrc/features/dataVisualizer/tree/DrawableTreeNode.tsxsrc/features/dataVisualizer/tree/FunctionTreeNode.tsxsrc/features/dataVisualizer/tree/Tree.tsxsrc/features/sicp/errors/SicpErrors.tsxsrc/features/sicp/errors/__tests__/SicpErrors.test.tsxsrc/features/sicp/parser/ParseJson.tsxsrc/pages/academy/adminPanel/subcomponents/AddStoriesUserPanel.tsxsrc/pages/academy/adminPanel/subcomponents/AddUserPanel.tsxsrc/pages/academy/adminPanel/subcomponents/assessmentConfigPanel/AssessmentConfigPanel.tsxsrc/pages/academy/adminPanel/subcomponents/storiesUserConfigPanel/StoriesUserConfigPanel.tsxsrc/pages/academy/adminPanel/subcomponents/userConfigPanel/UserConfigPanel.tsxsrc/pages/academy/gameSimulator/subcomponents/assetViewer/AssetViewer.tsxsrc/pages/academy/gameSimulator/subcomponents/assetViewer/AssetViewerUtils.tsxsrc/pages/githubCallback/__tests__/GitHubCallback.test.tsxsrc/pages/sicp/Sicp.tsxsrc/pages/sicp/__tests__/Sicp.test.tsxsrc/pages/sicp/subcomponents/SicpExercise.tsxsrc/pages/sicp/subcomponents/__tests__/CodeSnippet.test.tsxsrc/pages/sicp/subcomponents/__tests__/SicpLatex.test.tsxsrc/pages/sicp/subcomponents/chatbot/ChatBox.tsx
Oofky
added a commit
to Akshay-2007-1/CSE_liveness_frontend
that referenced
this pull request
Mar 17, 2026
commit 2979582 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Tue Mar 17 00:23:22 2026 +0000 chore(deps): update blueprintjs to v6.10.0 (source-academy#3673) * chore(deps): update blueprintjs to v6.10.0 * Update test snapshots --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Richard Dominick <34370238+RichDom2185@users.noreply.github.com> commit 9aef777 Author: Richard Dominick <34370238+RichDom2185@users.noreply.github.com> Date: Tue Mar 17 01:00:27 2026 +0800 Upgrade jsdom to v29 (source-academy#3672) * Upgrade jsdom to v29 * Update some snapshots * Fix tests * Increase test timeout commit 0ab537b Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Mar 16 16:06:50 2026 +0000 chore(deps): update dependency eslint-plugin-react-hooks to v7 (source-academy#3484) * chore(deps): update dependency eslint-plugin-react-hooks to v7 * Fix breaking changes --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Richard Dominick <34370238+RichDom2185@users.noreply.github.com> commit 5184d62 Author: Richard Dominick <34370238+RichDom2185@users.noreply.github.com> Date: Mon Mar 16 23:54:40 2026 +0800 Fix concurrent precache logic (source-academy#3671) * Create own copy of precaching-striping * Remove old version * Update SW * Fix `this` binding commit 2d06530 Author: Richard Dominick <34370238+RichDom2185@users.noreply.github.com> Date: Mon Mar 16 23:23:42 2026 +0800 Upgrade Vite/Vitest ecosystem dependencies to v8 (source-academy#3670) * Use modern `paths` format for tsconfig * Fix type imports * Upgrade Vite ecosystem to v8 * Fix missing await commit 4de3cfa Author: Richard Dominick <34370238+RichDom2185@users.noreply.github.com> Date: Mon Mar 16 23:19:34 2026 +0800 Concurrently precache assets (source-academy#3669) * Add precache-striping * Clean up rsbuild config * Remove now-unneeded Node polyfills * Fetch assets concurrently commit 01b028f Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Mar 16 22:50:53 2026 +0800 chore(deps): update dependency i18next to v25.8.18 (source-academy#3668) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 7e34573 Author: Richard Dominick <34370238+RichDom2185@users.noreply.github.com> Date: Mon Mar 16 22:45:11 2026 +0800 Group Renovate BlueprintJS updates (source-academy#3666) * Set up Renovate dep groups * Undo dev-deps groupign commit 07e9128 Author: Akshay-2007-1 <131676168+Akshay-2007-1@users.noreply.github.com> Date: Mon Mar 16 22:34:18 2026 +0800 CSE Machine : Fix nano bugs (source-academy#3667) * Fix nano bugs * Fix unnormalized line endings --------- Co-authored-by: Richard Dominick <34370238+RichDom2185@users.noreply.github.com> commit 5767324 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Mar 16 13:21:04 2026 +0000 chore(deps): update dependency react-i18next to v16.5.7 (source-academy#3664) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit c228254 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Mar 16 13:16:28 2026 +0000 chore(deps): update dependency @rsbuild/plugin-svgr to v1.3.1 (source-academy#3663) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 0095e10 Author: Richard Dominick <34370238+RichDom2185@users.noreply.github.com> Date: Mon Mar 16 21:12:49 2026 +0800 Upgrade React ecosystem dependencies to v19 (source-academy#3247) * Upgrade React ecosystem dependencies to v19 * Fix some breaking changes * Fix more breaking changes * Fix remaining codebase errors * Fix some test errors * Update AcademyNavigationBar.tsx * Fix remaining test error * Fix missed type bug * Remove deprecated react-test-renderer * Delete useless test * Update some snapshots * Update more snapshots * Fix some tests and snapshots * Update more snapshots * Update Repl tests * Update editor tests * Update lockfile post-merge * Fix JSX namespace errors * Update dependencies post-merge * Deduplicate dependencies * Update snapshots post-merge * Update lockfile post-merge * Update snapshots * Fix breaking type changes * Remove shallow render * Remove shallow render from tests * Remove unused import * Fix more tests * Clean up snapshots * Fix tests double render * Update snapshots * Replace react-sortable-hoc with dnd-kit * Update dep constraints * Install `@dnd-kit/core` * Migrate sortable list to dnd-kit * Fix tests rendering * Add TODOs * Address phantom dependency commit c928c31 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Mar 16 10:54:21 2026 +0000 chore(deps): update dependency sass to v1.98.0 (source-academy#3657) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 307a8d1 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Mar 16 10:50:20 2026 +0000 chore(deps): update dependency @rsbuild/plugin-sass to v1.5.1 (source-academy#3661) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit b132f3b Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Mar 16 10:46:40 2026 +0000 chore(deps): update dependency @rsbuild/plugin-react to v1.4.6 (source-academy#3660) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 9db226b Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Mar 16 10:42:57 2026 +0000 chore(deps): update dependency dompurify to v3.3.3 (source-academy#3658) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 298b27f Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Mar 16 18:37:22 2026 +0800 chore(deps): update dependency @sentry/react to v10.43.0 (source-academy#3656) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 7f33412 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Mar 15 12:27:50 2026 +0000 chore(deps): update dependency typescript-eslint to v8.57.0 (source-academy#3654) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 20933ef Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Mar 15 12:23:36 2026 +0000 chore(deps): update dependency react-simple-keyboard to v3.8.172 (source-academy#3655) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 93ec2a6 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Mar 15 12:19:41 2026 +0000 chore(deps): update dependency eslint to v9.39.4 (source-academy#3649) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 0024c6a Author: Roger Zhang <rogerteo200@gmail.com> Date: Sun Mar 15 20:16:24 2026 +0800 QOL: Arrows bending too early or too late (source-academy#3653) * feat: colour-coding arrows * feat: removed colour-coding for arrows (all white), implemented feature where clicked arrows remain highlighted * fix: removed whitespace * fix: bugfix and linting * test2 * fix: Refactor arrow selection management and clean up code style * fix: ran linter * fix: snapshots * fix: change to american english for the word "color" * fix: faded arrows now stay faded * test * test * fix: prematurely terminating arrows * added global MinTerminalSegmentLength commit 4b9af0d Author: Akshay-2007-1 <131676168+Akshay-2007-1@users.noreply.github.com> Date: Fri Mar 13 17:56:39 2026 +0800 CSE Machine : Fixes Cache and Arrow displacement errors (source-academy#3650) * Fixed arrow change! * Fixed the cache difference issue * Fixed tsc error - II commit ff7ab4f Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed Mar 11 14:23:57 2026 +0800 chore(deps): update dependency react-i18next to v16.5.5 (source-academy#3648) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit b822ca5 Author: Ho Ke Ying <168710875+Oofky@users.noreply.github.com> Date: Wed Mar 11 01:09:26 2026 +0800 Changed hotkey for hulk mode (source-academy#3647) Changed from alt+shift+h to ctrl+alt+h commit 90066a6 Author: Akshay-2007-1 <131676168+Akshay-2007-1@users.noreply.github.com> Date: Tue Mar 10 20:54:53 2026 +0800 Hulk fix (source-academy#3600) * Hulk Fix! Initial commit * Changed the faded colours to fit Fits the green screen background better for a faded effect * Fixed the formatting! * Revert foreground colors For its intended use on dark backgrounds after chroma keying * Fixed formatting --------- Co-authored-by: Oofky <beensprouting@gmail.com> commit 797aecd Author: Akshay-2007-1 <131676168+Akshay-2007-1@users.noreply.github.com> Date: Tue Mar 10 14:31:17 2026 +0800 CSE Machine : Function Descriptions modification for Frame overlap (source-academy#3627) * Added the removeDeadFrames feature Only dead frames disappear as of right now, for function objects and the rest, work to be done Animations : will be done by Keying! * Added the functionality for toggle of dead vs ONLY live for function closure objects Generic Arrow Text (recursively automated) Arrays and hence pairs as well * Fix : Removed gaps Finally processed the logic by recomputing the envTree for the specific step when the toggle is on * Fix : CI format errors and made it from checkbox -> onClick button! * Fix : Toggle -> One time cleanup * Changed from Hide -> Clear and the icon * Fixed the following errors and implemented suggestions 1. Fixed the snapshot and lint erros 2. Added the disable feature (as suggested by @sayomaki) where to suggest that its CLEAR and not HIDE, we disable after pressing once!! 3. Changed all instances of hide to clear in our current implementation! * Fixed tsc error * Fixed the sentry bot suggestion * Fixed the error where the frames WERE not moving due to the Layout team's invariant! Now the frames do move by violating their invariant ONLY if the Clear mode is ON * Version 1 * Version 2 * Added the following functionalities 1. Capped out the func desc box's widths 2. Click to reveal FULL length descriptions in normal mode 3. Fixed gaps between the FRAMES in PRINTABLE mode * Fixed a bug where the gap between two frames was not dynamically being set and was capped out! 1. This makes every other test case which we have made look MUCH better! 2. Secondly, we also fixed a bug where recursive closure objects' description boxes' width and length was NOT being accounted for * Fixed format error * cse layout: normalize frame width accounting and add printable fn description spacing - normalize Frame width semantics: - totalWidth now represents only frame block width - totalDataWidth is computed as true overflow beyond frame right edge - remove pre-estimation path that double-counted spacing in some cases - update Level width derivation to include last frame totalDataWidth - improve printable mode readability for function descriptions: - add small vertical offset above printable fn description labels - add tiny bottom gap below printable fn description boxes - propagate new spacing to Binding and ArrayValue height calculations This reduces excessive horizontal gaps and mitigates small printable-mode overlaps between fn description boxes and nearby array/binding content. Also removed the excess frame offset width given for safety that was NOT dynamic! So now, the frame width gapping is dynamic! * Fixed format errors * Fixed sentry's bot error * Fixed source-academy#3639 by adding closing parantheses * Fix stationary x-coordinates for normal and printable modes: - Populates both Normal and Printable caches upfront in drawCse. - Removes redundant cache generation logic from redraw. - Prevents premature cache clearing in clearCse to maintain stability. * removed comments and console logs * Fixed format errors --------- Co-authored-by: Martin Henz <henz@comp.nus.edu.sg> Co-authored-by: Richard Dominick <34370238+RichDom2185@users.noreply.github.com> Co-authored-by: gigopogy <ethanlockzy@gmail.com> commit 3e7e0df Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Tue Mar 10 11:55:38 2026 +0800 chore(deps): update dependency react-simple-keyboard to v3.8.168 (source-academy#3644) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit e678e7e Author: Ho Ke Ying <168710875+Oofky@users.noreply.github.com> Date: Tue Mar 10 06:30:00 2026 +0800 Fixed liveness bug for null array units (source-academy#3642) * Fixed null array units liveness Fixed the issue where null array units sometimes still have the default stroke color, despite being dead * Fixed format errors --------- Co-authored-by: Martin Henz <henz@comp.nus.edu.sg> commit d331a5d Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Mar 9 20:28:37 2026 +0000 chore(deps): update dependency @swc/core to v1.15.18 (source-academy#3636) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit fbf7e64 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Mar 9 20:23:15 2026 +0000 chore(deps): update dependency i18next to v25.8.14 (source-academy#3640) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit e0649aa Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Mar 9 20:14:09 2026 +0000 chore(deps): update dependency dompurify to v3.3.2 [security] (source-academy#3635) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 2563a62 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Mar 9 20:05:44 2026 +0000 chore(deps): update dependency @sentry/react to v10.41.0 (source-academy#3638) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 094601a Author: Richard Dominick <34370238+RichDom2185@users.noreply.github.com> Date: Tue Mar 10 04:00:38 2026 +0800 Fix lockfile and other incorrect changes (source-academy#3643) * Revert some lockfile changes from 1088 * Bump Yarn to 4.13.0 * Fix snapshots commit 49dadc8 Author: Akshay-2007-1 <131676168+Akshay-2007-1@users.noreply.github.com> Date: Thu Mar 5 23:39:45 2026 +0800 CSE Machine : Fixed the NavBar (source-academy#3630) * Fixed the errors * Fixed format errors * Fixed inequality overlook
RichDom2185
pushed a commit
that referenced
this pull request
Apr 6, 2026
* Added the removeDeadFrames feature
Only dead frames disappear as of right now, for function objects and the rest, work to be done
Animations : will be done by Keying!
* Added the functionality for toggle of dead vs ONLY live for
function closure objects
Generic Arrow
Text (recursively automated)
Arrays and hence pairs as well
* Fix : Removed gaps
Finally processed the logic by recomputing the envTree for the specific step when the toggle is on
* Fix : CI format errors and made it from checkbox -> onClick button!
* Fix : Toggle -> One time cleanup
* Changed from Hide -> Clear and the icon
* WIP logic for Clear Dead Frames animation
Currently, the animations do not play.
Putting these changes into a branch because I want to save these changes so that I can fully rewrite playClearDeadFramesAnim() while having a backup in case my new idea does not work.
* Frames have a shifting animation now
After clicking Clear Dead Frames, frames that get shifted (to close gaps) now have an animation moving from their old position to their new position.
To do:
- animate other objects, not just frames
- possibly cover up the "new frames" before the animation finishes
* "New frames" are covered up
Now you cannot see the new frames before the frame shifting animation finishes.
Test code (for my own easy access):
function foo() {
function f(x) {
return y => x + 3;
}
return f;
}
foo()(4);
foo()(5);
To do:
- Make frame text (from bindings) move with the frame. This should be implemented with AnimatedTextComponent rather than AnimatedTextbox because there are multiple bindings per frame and the texts are linked to each binding rather than its frame.
- Consider whether the frame's name (text) should move along with the frame.
- Consider whether arrows should be animated (likely not, as the arrows can change shape so it might look weird / be hard to implement).
- Move function objects and arrays along with the frame.
* Squashed commit of the following:
commit 2979582
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date: Tue Mar 17 00:23:22 2026 +0000
chore(deps): update blueprintjs to v6.10.0 (#3673)
* chore(deps): update blueprintjs to v6.10.0
* Update test snapshots
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Richard Dominick <34370238+RichDom2185@users.noreply.github.com>
commit 9aef777
Author: Richard Dominick <34370238+RichDom2185@users.noreply.github.com>
Date: Tue Mar 17 01:00:27 2026 +0800
Upgrade jsdom to v29 (#3672)
* Upgrade jsdom to v29
* Update some snapshots
* Fix tests
* Increase test timeout
commit 0ab537b
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon Mar 16 16:06:50 2026 +0000
chore(deps): update dependency eslint-plugin-react-hooks to v7 (#3484)
* chore(deps): update dependency eslint-plugin-react-hooks to v7
* Fix breaking changes
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Richard Dominick <34370238+RichDom2185@users.noreply.github.com>
commit 5184d62
Author: Richard Dominick <34370238+RichDom2185@users.noreply.github.com>
Date: Mon Mar 16 23:54:40 2026 +0800
Fix concurrent precache logic (#3671)
* Create own copy of precaching-striping
* Remove old version
* Update SW
* Fix `this` binding
commit 2d06530
Author: Richard Dominick <34370238+RichDom2185@users.noreply.github.com>
Date: Mon Mar 16 23:23:42 2026 +0800
Upgrade Vite/Vitest ecosystem dependencies to v8 (#3670)
* Use modern `paths` format for tsconfig
* Fix type imports
* Upgrade Vite ecosystem to v8
* Fix missing await
commit 4de3cfa
Author: Richard Dominick <34370238+RichDom2185@users.noreply.github.com>
Date: Mon Mar 16 23:19:34 2026 +0800
Concurrently precache assets (#3669)
* Add precache-striping
* Clean up rsbuild config
* Remove now-unneeded Node polyfills
* Fetch assets concurrently
commit 01b028f
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon Mar 16 22:50:53 2026 +0800
chore(deps): update dependency i18next to v25.8.18 (#3668)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
commit 7e34573
Author: Richard Dominick <34370238+RichDom2185@users.noreply.github.com>
Date: Mon Mar 16 22:45:11 2026 +0800
Group Renovate BlueprintJS updates (#3666)
* Set up Renovate dep groups
* Undo dev-deps groupign
commit 07e9128
Author: Akshay-2007-1 <131676168+Akshay-2007-1@users.noreply.github.com>
Date: Mon Mar 16 22:34:18 2026 +0800
CSE Machine : Fix nano bugs (#3667)
* Fix nano bugs
* Fix unnormalized line endings
---------
Co-authored-by: Richard Dominick <34370238+RichDom2185@users.noreply.github.com>
commit 5767324
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon Mar 16 13:21:04 2026 +0000
chore(deps): update dependency react-i18next to v16.5.7 (#3664)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
commit c228254
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon Mar 16 13:16:28 2026 +0000
chore(deps): update dependency @rsbuild/plugin-svgr to v1.3.1 (#3663)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
commit 0095e10
Author: Richard Dominick <34370238+RichDom2185@users.noreply.github.com>
Date: Mon Mar 16 21:12:49 2026 +0800
Upgrade React ecosystem dependencies to v19 (#3247)
* Upgrade React ecosystem dependencies to v19
* Fix some breaking changes
* Fix more breaking changes
* Fix remaining codebase errors
* Fix some test errors
* Update AcademyNavigationBar.tsx
* Fix remaining test error
* Fix missed type bug
* Remove deprecated react-test-renderer
* Delete useless test
* Update some snapshots
* Update more snapshots
* Fix some tests and snapshots
* Update more snapshots
* Update Repl tests
* Update editor tests
* Update lockfile post-merge
* Fix JSX namespace errors
* Update dependencies post-merge
* Deduplicate dependencies
* Update snapshots post-merge
* Update lockfile post-merge
* Update snapshots
* Fix breaking type changes
* Remove shallow render
* Remove shallow render from tests
* Remove unused import
* Fix more tests
* Clean up snapshots
* Fix tests double render
* Update snapshots
* Replace react-sortable-hoc with dnd-kit
* Update dep constraints
* Install `@dnd-kit/core`
* Migrate sortable list to dnd-kit
* Fix tests rendering
* Add TODOs
* Address phantom dependency
commit c928c31
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon Mar 16 10:54:21 2026 +0000
chore(deps): update dependency sass to v1.98.0 (#3657)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
commit 307a8d1
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon Mar 16 10:50:20 2026 +0000
chore(deps): update dependency @rsbuild/plugin-sass to v1.5.1 (#3661)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
commit b132f3b
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon Mar 16 10:46:40 2026 +0000
chore(deps): update dependency @rsbuild/plugin-react to v1.4.6 (#3660)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
commit 9db226b
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon Mar 16 10:42:57 2026 +0000
chore(deps): update dependency dompurify to v3.3.3 (#3658)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
commit 298b27f
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon Mar 16 18:37:22 2026 +0800
chore(deps): update dependency @sentry/react to v10.43.0 (#3656)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
commit 7f33412
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date: Sun Mar 15 12:27:50 2026 +0000
chore(deps): update dependency typescript-eslint to v8.57.0 (#3654)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
commit 20933ef
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date: Sun Mar 15 12:23:36 2026 +0000
chore(deps): update dependency react-simple-keyboard to v3.8.172 (#3655)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
commit 93ec2a6
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date: Sun Mar 15 12:19:41 2026 +0000
chore(deps): update dependency eslint to v9.39.4 (#3649)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
commit 0024c6a
Author: Roger Zhang <rogerteo200@gmail.com>
Date: Sun Mar 15 20:16:24 2026 +0800
QOL: Arrows bending too early or too late (#3653)
* feat: colour-coding arrows
* feat: removed colour-coding for arrows (all white), implemented feature where clicked arrows remain highlighted
* fix: removed whitespace
* fix: bugfix and linting
* test2
* fix: Refactor arrow selection management and clean up code style
* fix: ran linter
* fix: snapshots
* fix: change to american english for the word "color"
* fix: faded arrows now stay faded
* test
* test
* fix: prematurely terminating arrows
* added global MinTerminalSegmentLength
commit 4b9af0d
Author: Akshay-2007-1 <131676168+Akshay-2007-1@users.noreply.github.com>
Date: Fri Mar 13 17:56:39 2026 +0800
CSE Machine : Fixes Cache and Arrow displacement errors (#3650)
* Fixed arrow change!
* Fixed the cache difference issue
* Fixed tsc error - II
commit ff7ab4f
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date: Wed Mar 11 14:23:57 2026 +0800
chore(deps): update dependency react-i18next to v16.5.5 (#3648)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
commit b822ca5
Author: Ho Ke Ying <168710875+Oofky@users.noreply.github.com>
Date: Wed Mar 11 01:09:26 2026 +0800
Changed hotkey for hulk mode (#3647)
Changed from alt+shift+h to ctrl+alt+h
commit 90066a6
Author: Akshay-2007-1 <131676168+Akshay-2007-1@users.noreply.github.com>
Date: Tue Mar 10 20:54:53 2026 +0800
Hulk fix (#3600)
* Hulk Fix!
Initial commit
* Changed the faded colours to fit
Fits the green screen background better for a faded effect
* Fixed the formatting!
* Revert foreground colors
For its intended use on dark backgrounds after chroma keying
* Fixed formatting
---------
Co-authored-by: Oofky <beensprouting@gmail.com>
commit 797aecd
Author: Akshay-2007-1 <131676168+Akshay-2007-1@users.noreply.github.com>
Date: Tue Mar 10 14:31:17 2026 +0800
CSE Machine : Function Descriptions modification for Frame overlap (#3627)
* Added the removeDeadFrames feature
Only dead frames disappear as of right now, for function objects and the rest, work to be done
Animations : will be done by Keying!
* Added the functionality for toggle of dead vs ONLY live for
function closure objects
Generic Arrow
Text (recursively automated)
Arrays and hence pairs as well
* Fix : Removed gaps
Finally processed the logic by recomputing the envTree for the specific step when the toggle is on
* Fix : CI format errors and made it from checkbox -> onClick button!
* Fix : Toggle -> One time cleanup
* Changed from Hide -> Clear and the icon
* Fixed the following errors and implemented suggestions
1. Fixed the snapshot and lint erros
2. Added the disable feature (as suggested by @sayomaki) where to suggest that its CLEAR and not HIDE, we disable after pressing once!!
3. Changed all instances of hide to clear in our current implementation!
* Fixed tsc error
* Fixed the sentry bot suggestion
* Fixed the error where the frames WERE not moving due to the Layout team's invariant!
Now the frames do move by violating their invariant ONLY if the Clear mode is ON
* Version 1
* Version 2
* Added the following functionalities
1. Capped out the func desc box's widths
2. Click to reveal FULL length descriptions in normal mode
3. Fixed gaps between the FRAMES in PRINTABLE mode
* Fixed a bug where the gap between two frames was not dynamically being set and was capped out!
1. This makes every other test case which we have made look MUCH better!
2. Secondly, we also fixed a bug where recursive closure objects' description boxes' width and length was NOT being
accounted for
* Fixed format error
* cse layout: normalize frame width accounting and add printable fn description spacing
- normalize Frame width semantics:
- totalWidth now represents only frame block width
- totalDataWidth is computed as true overflow beyond frame right edge
- remove pre-estimation path that double-counted spacing in some cases
- update Level width derivation to include last frame totalDataWidth
- improve printable mode readability for function descriptions:
- add small vertical offset above printable fn description labels
- add tiny bottom gap below printable fn description boxes
- propagate new spacing to Binding and ArrayValue height calculations
This reduces excessive horizontal gaps and mitigates small printable-mode overlaps between fn description boxes
and nearby array/binding content.
Also removed the excess frame offset width given for safety that was NOT dynamic!
So now, the frame width gapping is dynamic!
* Fixed format errors
* Fixed sentry's bot error
* Fixed #3639 by adding closing parantheses
* Fix stationary x-coordinates for normal and printable modes:
- Populates both Normal and Printable caches upfront in drawCse.
- Removes redundant cache generation logic from redraw.
- Prevents premature cache clearing in clearCse to maintain stability.
* removed comments and console logs
* Fixed format errors
---------
Co-authored-by: Martin Henz <henz@comp.nus.edu.sg>
Co-authored-by: Richard Dominick <34370238+RichDom2185@users.noreply.github.com>
Co-authored-by: gigopogy <ethanlockzy@gmail.com>
commit 3e7e0df
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date: Tue Mar 10 11:55:38 2026 +0800
chore(deps): update dependency react-simple-keyboard to v3.8.168 (#3644)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
commit e678e7e
Author: Ho Ke Ying <168710875+Oofky@users.noreply.github.com>
Date: Tue Mar 10 06:30:00 2026 +0800
Fixed liveness bug for null array units (#3642)
* Fixed null array units liveness
Fixed the issue where null array units sometimes still have the default stroke color, despite being dead
* Fixed format errors
---------
Co-authored-by: Martin Henz <henz@comp.nus.edu.sg>
commit d331a5d
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon Mar 9 20:28:37 2026 +0000
chore(deps): update dependency @swc/core to v1.15.18 (#3636)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
commit fbf7e64
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon Mar 9 20:23:15 2026 +0000
chore(deps): update dependency i18next to v25.8.14 (#3640)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
commit e0649aa
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon Mar 9 20:14:09 2026 +0000
chore(deps): update dependency dompurify to v3.3.2 [security] (#3635)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
commit 2563a62
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon Mar 9 20:05:44 2026 +0000
chore(deps): update dependency @sentry/react to v10.41.0 (#3638)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
commit 094601a
Author: Richard Dominick <34370238+RichDom2185@users.noreply.github.com>
Date: Tue Mar 10 04:00:38 2026 +0800
Fix lockfile and other incorrect changes (#3643)
* Revert some lockfile changes from 1088
* Bump Yarn to 4.13.0
* Fix snapshots
commit 49dadc8
Author: Akshay-2007-1 <131676168+Akshay-2007-1@users.noreply.github.com>
Date: Thu Mar 5 23:39:45 2026 +0800
CSE Machine : Fixed the NavBar (#3630)
* Fixed the errors
* Fixed format errors
* Fixed inequality overlook
* Revert "Squashed commit of the following:"
This reverts commit 516fd22.
* Binding keys' text moves with frames
Currently, binding values don't move, including texts. Only the text of keys move.
Test code (for my own easy access):
function foo() {
function f(x) {
function g() {
const y = list(1, 2);
return y;
}
return g;
}
return f;
}
foo()(4)();
foo()(5)();
New issue:
- For some reason, the array value in the above code disappears after clicking Clear Dead Frames, but it reappears if we click print mode.
To do:
- Make binding values move with the frame. This should be implemented for each type of value, for example array or func object or primitive text.
- Consider whether the frame's name (text) should move along with the frame.
- Consider whether arrows should be animated (likely not, as the arrows can change shape so it might look weird / be hard to implement).
- Move function objects and arrays along with the frame. (Ones that may not be binded, unless invisible bindings handle this)
* PrimitiveValue texts move + dummy bindings dont
Primitive text values now move with the frame! Fixed an issue where dummy bindings were appearing during the animation, which was unintended.
* FnObjects shift, but new major problem
Saving this in case I want to revert while fixing major problem
* FnObjects shift properly, major problem fixed
* Arrays mostly shift properly
Except ArrayNullUnit and text primitive values. Text primitive values have a weird offset that needs to be accounted for.
Test code (for my own easy access):
function foo() {
function f(x) {
let r = [1, 2, () => 2];
function g() {
const y = list(1, () => 2);
let k = [];
return () => y[0];
}
return g;
}
return f;
}
foo()(4)();
foo()(5)()();
TODO:
1. Create ArrayNullUnit animation
2. Fix text primitive values animation
3. Make arrows disappear during the animation, because animating the arrows is not a feasible idea
4. Possibly clean up the code, as currently there is a lot of repeated code
* Changed text to truncated version
* Fixed imports
* Update src/features/cseMachine/animationComponents/ClearDeadFramesAnimation.tsx
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
* Update src/features/cseMachine/CseMachineUtils.ts
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
* Update src/features/cseMachine/animationComponents/ClearDeadFramesAnimation.tsx
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
* Arrows now are HIDDEN during animation
* Fixed formatting
* ArrayNullUnits shift
* Fixed imports
* Fixed formatting
* Fixed bug as suggested by Gemini
To do: Center alignment does not work with the animations right now and crashes. This needs to be fixed or animations should be disabled when center alignment is switched on.
* Added try finally for restoring Layout.draw
* Fixed the global frame's built in funcs disappearance
* Fixed formatting
* Added defensive checks suggested by sentry bot
* Remove the grey covers
* Fixed formatting and globalFns not responding to animation
* Text moving FAR too left? not anymore!
* annoying format and tsc error
* Frame names animation
* Update src/features/cseMachine/animationComponents/ClearDeadFramesAnimation.tsx
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
* stupid Gemini mistake
* Deleted accidental duplicated code
* Readded KonvaGroup related to Zoom and Save fix
* Log warning instead of throw error
* Fixed formatting
* Added check for duplicate functions / arrays
+ added defensive check as requested by sentry
* Weird git didnt push my code fully
---------
Co-authored-by: Vemulapalli Akshay <akshayvemulapalli2007@gmail.com>
Co-authored-by: Akshay-2007-1 <131676168+Akshay-2007-1@users.noreply.github.com>
Co-authored-by: Akshay-2007-1 <e1668621@u.nus.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As per title. Upgrades React to v19, as well as the other related dependencies that must be upgraded together.
Also migrated from
react-sortable-hocto dnd-kit since the former is no longer maintained and broken as of React 19.How to test
Everything should still work.
Checklist