[build] Refine some build targets to match with build infrastructure. #24967
+8
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Shilong Liu <shilongliu@microsoft.com>
liushilongbuaa
force-pushed
the
buildinfra
branch
from
ffa4df1 to
e4c7e80
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liushilongbuaa
requested review from
lguohan,
qiluo-msft and
xumia
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines build targets to better align with the build infrastructure, focusing on three main improvements: separating test and build logic for eventd, fixing dependency tracking for device files to prevent unnecessary rebuilds, and relocating telemetry-sidecar tests to use the standard cli-plugin-tests framework.
- Separated build and test targets in sonic-eventd Makefile to allow debian-helper to run them in different build steps
- Centralized device file dependency tracking using SONIC_DEVICE_FILES_LIST to prevent unnecessary rebuilds caused by git-ignored files
- Moved telemetry-sidecar unit tests from a custom Makefile target to the standard cli-plugin-tests directory with proper PYTHONPATH configuration
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/sonic-eventd/Makefile | Split all target to exclude tests; added separate test target for debian-helper compatibility |
| slave.mk | Added PYTHONPATH to cli-plugin-tests execution to allow tests to import modules from parent docker directory |
| rules/sonic-device-data.dep | Replaced inline find command with centralized SONIC_DEVICE_FILES_LIST variable |
| rules/sonic-config.dep | Replaced inline find command with centralized SONIC_DEVICE_FILES_LIST variable; removed duplicate device file pattern |
| rules/docker-telemetry-sidecar.mk | Removed custom unit test target that was causing unnecessary docker rebuilds |
| dockers/docker-telemetry-sidecar/cli-plugin-tests/test_systemd_stub.py | New comprehensive test suite for systemd_stub.py covering sync operations, CONFIG_DB reconciliation, and file management |
| Makefile.cache | Added SONIC_DEVICE_FILES_LIST definition using git ls-files to track device files excluding symlinks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)