Skip to content

Fix sandbox lookbook installation#6417

Merged
jarednorman merged 1 commit intosolidusio:mainfrom
SuperGoodSoft:alistair/fix-sandbox-bundle
Feb 16, 2026
Merged

Fix sandbox lookbook installation#6417
jarednorman merged 1 commit intosolidusio:mainfrom
SuperGoodSoft:alistair/fix-sandbox-bundle

Conversation

@AlistairNorman
Copy link
Copy Markdown
Contributor

Summary

bin/sandbox is erroring right now. We just need a slightly different command because the bundle when installing lookbook fails. This fixes #6416

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

Running execute_command here tries to run `bin/bundle install` instead
of just running `bundle install`. bin/bundle doesn't exist so it errors
and lookbook is not installed and then route command after this fails,
causing the sandbox install to be aborted.
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.50%. Comparing base (1db0767) to head (0db9d44).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...erators/solidus_admin/install/install_generator.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6417   +/-   ##
=======================================
  Coverage   89.50%   89.50%           
=======================================
  Files         981      981           
  Lines       20479    20479           
=======================================
  Hits        18330    18330           
  Misses       2149     2149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jarednorman jarednorman merged commit b2b3f2e into solidusio:main Feb 16, 2026
43 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

bin/sandbox fails with Could not find gem 'lookbook'

3 participants