Skip to content

Fix exports disappearing #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huseeiin wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix exports disappearing #2104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
483adb4
fix exports becoming undefined
huseeiin Mar 14, 2026
0da494b
format
huseeiin Mar 14, 2026
4b7c29a
fix type error
huseeiin Mar 14, 2026
c3b5d32
add changeset
huseeiin Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quiet-deserts-clap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@solidjs/start": minor
---

fixed exports getting lost
53 changes: 35 additions & 18 deletions packages/start/src/config/fs-routes/tree-shake.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,57 +108,74 @@ function treeShakeTransform({ types: t }: typeof Babel): PluginObj<State> {
}
},
ExportDefaultDeclaration(exportNamedPath) {
// if opts.keep is true, we don't remove the routeData export
if (state.opts.pick && !state.opts.pick.includes("default")) {
exportNamedPath.remove();
const decl = exportNamedPath.get("declaration");
if (decl.node) {
// Keep the declaration, just remove the export
exportNamedPath.replaceWith(decl.node);
} else {
exportNamedPath.remove();
}
}
},
ExportNamedDeclaration(exportNamedPath) {
// if opts.keep is false, we don't remove the routeData export
if (!state.opts.pick) {
return;
}

const specifiers = exportNamedPath.get("specifiers");

// Handle: export { foo, bar }
if (specifiers.length) {
specifiers.forEach(s => {
if (
t.isIdentifier(s.node.exported)
? s.node.exported.name
: state.opts.pick.includes(s.node.exported.value)
) {
s.remove();
const exportedName = t.isIdentifier(s.node.exported)
? s.node.exported.name
: s.node.exported.value;
if (!state.opts.pick.includes(exportedName)) {
s.remove(); // Remove from export list, but keep the local binding
}
});
if (exportNamedPath.node.specifiers.length < 1) {
exportNamedPath.remove();
exportNamedPath.remove(); // Remove empty export statement
}
return;
}

const decl = exportNamedPath.get("declaration");
if (decl == null || decl.node == null) {
return;
}

switch (decl.node.type) {
case "FunctionDeclaration": {
const name = decl.node.id?.name;
if (name && state.opts.pick && !state.opts.pick.includes(name)) {
exportNamedPath.remove();
if (name && !state.opts.pick.includes(name)) {
// REPLACE export function foo() {} with function foo() {}
// Don't remove - just remove the export!
exportNamedPath.replaceWith(decl.node);
}
break;
}
case "VariableDeclaration": {
const inner = decl.get("declarations") as Array<NodePath<any>>;
const inner = decl.get("declarations");
inner.forEach(d => {
if (d.node.id.type !== "Identifier") {
return;
}
if (d.node.id.type !== "Identifier") return;
const name = d.node.id.name;
if (state.opts.pick && !state.opts.pick.includes(name)) {
d.remove();
if (!state.opts.pick.includes(name)) {
// Keep the variable, just not exported
// Replace export const foo = ... with const foo = ...
exportNamedPath.replaceWith(decl.node!);
}
});
break;
}
case "ClassDeclaration": {
const name = decl.node.id?.name;
if (name && !state.opts.pick.includes(name)) {
exportNamedPath.replaceWith(decl.node);
}
break;
}
default: {
break;
}
Expand Down
Loading