Conversation
🦋 Changeset detectedLatest commit: a457571 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
atilafassina
force-pushed
the
tests/data
branch
from
c1e640e to
2af1d86
Compare
atilafassina
force-pushed
the
infra/module-resolution
branch
3 times, most recently
from
c7168da to
4a543bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR looks big because of the number of mocks and tests added.
Logic change is quite small.
actioncreateAsynceventsqueryresponseThere are some formatting changes. It's worth to consider adding a linter config on a later PR.
Touched some logic
Tests pointed out that
actionandcreateAsyncwere not respecting user definedname. Moreover,actionwas not applying the hashed name and only naming the action"mutate", I believe my changes brought it closer to original intentions, but I can revert them otherwise.