fix: createAsync - catch errors of prev to avoid bubbling error up#531
Merged
ryansolid merged 4 commits intosolidjs:mainfrom Nov 10, 2025
Merged
fix: createAsync - catch errors of prev to avoid bubbling error up#531ryansolid merged 4 commits intosolidjs:mainfrom
ryansolid merged 4 commits intosolidjs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 8885abf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
removed "test" from root tsconfig
Ensure that errors from previous async calls are caught to prevent them from bubbling up.
Member
|
Thank you. There are definitely some gaps because the way we hacked around createResource. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently when the inner function of createAsync's inner function throws after an arg has updated, the error will not be caught by the closest ErrorBoundary that wraps the accessor. It will bubble up instead. Which is kind of inconsistent, because if there is an initial error it will be caught by the closest ErrorBoundary
wrapping the the prev in catchError and returning undefined instead resolves this.
Also added tests for a few different simple scenarios of create async.
Simple reproduction