This repository was archived by the owner on Sep 17, 2024. It is now read-only.
Added black color to each flow_portal languages#222
Open
tommywong-dev wants to merge 2 commits intosolidjs:mainfrom
Open
Added black color to each flow_portal languages#222tommywong-dev wants to merge 2 commits intosolidjs:mainfrom
tommywong-dev wants to merge 2 commits intosolidjs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What I have noticed is that, the text inside the portal is unreadable at dark mode since it will automatically make texts white by default.
To overcome this, I have suggested to put a text color of
#333in the portal class, which is the default color for black color in browser.I have also proposed the same change to every possible languages of tutorials out there.
Before
After