Replace Ava with Vitest for testing JS client #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorisleiva
commented
Dec 5, 2025
Comment on lines
-19
to
-25
| { | ||
| ...SHARED_OPTIONS, | ||
| bundle: false, | ||
| entry: ['./test/**/*.ts'], | ||
| format: 'cjs', | ||
| outDir: './dist/test', | ||
| }, |
Member
Author
There was a problem hiding this comment.
This means we no longer have to run pnpm build before pnpm test.
joncinque
approved these changes
Dec 5, 2025
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Makes sense to me, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the Ava testing framework with Vitest for the JS client.
This means we can now remove the step that builds TypeScript test so that Ava can run them. This also means we get the nice watcher mode from Vitest (under the
pnpm devscript).By default the timeout is 5s in Vitest and 10s in Ava so I had to bump that up in the Vitest config but I'm hoping we can remove that change once we use something like LiteSVM for testing.