Skip to content

program: update solana-security-txt#662

Merged
2501babe merged 1 commit intosolana-program:mainfrom
2501babe:20260413_sectxt
Apr 13, 2026
Merged

program: update solana-security-txt#662
2501babe merged 1 commit intosolana-program:mainfrom
2501babe:20260413_sectxt

Conversation

@2501babe
Copy link
Copy Markdown
Member

@2501babe 2501babe commented Apr 13, 2026

as i discovered doing solana-program/stake#360 mailto is a syntax error:

query-security-txt ../target/deploy/spl_stake_pool.so
Error:
   0: Invalid contact `mailto:security@anza.xyz`

Location:
   /home/hana/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/query-security-txt-1.1.2/src/main.rs:35

i was going to leave the release/commit fields alone thinking this repo had its own style but i believe the hardcoded approach is fundamentally incorrect

it is possible, albeit an easy thing to overlook, to set up the github tag string in advance of a github release. its not possible for a github tag done after a release to be right, and its impossible for a hardcoded commit string to ever be right (unless you want to play with quine stuff), because we care about what these values are as of the github tagged commit. we deploy builds based on the tagged commits so by fixing metadata separately we just end up deploying binaries with the wrong values

@2501babe 2501babe self-assigned this Apr 13, 2026
@2501babe 2501babe marked this pull request as ready for review April 13, 2026 20:25
@2501babe 2501babe requested a review from joncinque April 13, 2026 20:26
Copy link
Copy Markdown
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@2501babe 2501babe merged commit 0438d99 into solana-program:main Apr 13, 2026
20 checks passed
@2501babe 2501babe deleted the 20260413_sectxt branch April 13, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants