Skip to content

cli: allow keypairs to be specified for all commands#341

Merged
joncinque merged 2 commits intosolana-program:mainfrom
wowinter13:fix-required-idjson
Apr 1, 2026
Merged

cli: allow keypairs to be specified for all commands#341
joncinque merged 2 commits intosolana-program:mainfrom
wowinter13:fix-required-idjson

Conversation

@wowinter13
Copy link
Copy Markdown
Contributor

Fixes #23

All commands should allow keypairs to be specified on the command line and not read ~/.config/solana/id.json

@wowinter13 wowinter13 changed the title fix(cli): requires id.json for all actions fix(cli): allow keypairs to be specified for all commands Jul 5, 2025
Copy link
Copy Markdown
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! This makes sense to me, just a nit on the naming

Comment on lines +2348 to +2351
Arg::with_name("keypair_path")
.long("keypair-path")
.short("k")
.value_name("PATH")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: let's update these to be consistent with the solana CLI

Suggested change
Arg::with_name("keypair_path")
.long("keypair-path")
.short("k")
.value_name("PATH")
Arg::with_name("keypair")
.long("keypair")
.short("k")
.value_name("KEYPAIR")

@joncinque joncinque force-pushed the fix-required-idjson branch from ae53678 to 495175b Compare March 31, 2026 23:05
@joncinque joncinque changed the title fix(cli): allow keypairs to be specified for all commands cli: allow keypairs to be specified for all commands Mar 31, 2026
Copy link
Copy Markdown
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@joncinque joncinque merged commit b2cbb22 into solana-program:main Apr 1, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cli: requires id.json for all actions

3 participants