fix separator error, height dropdown error#228
Open
vitorizkiimanda wants to merge 1 commit intosohobloo:masterfrom
Open
fix separator error, height dropdown error#228vitorizkiimanda wants to merge 1 commit intosohobloo:masterfrom
vitorizkiimanda wants to merge 1 commit intosohobloo:masterfrom
Conversation
|
Hey @vitorizkiimanda, I'm not a contributor to this library but I can let you know that your pull request can't be considered while it includes all of these unrelated changes, including changing indentation. Try to reduce your PR to only the lines that provide the change in behaviour, which might include line 413. Also, it's not usual practice to add a line like "* Modifiedd by vitorizkiimanda on 19/01/10." with your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separator not working, fixed by change '||' into '&&' -> logical error
Dropdown height hardcoded leading to missing height modal on dynamic options number, fixed by deleting height on style -> styling error