Remove redundant workflow step with invalid step reference#6
Closed
Copilot wants to merge 3 commits intosubmit_test-updatesfrom
Closed
Remove redundant workflow step with invalid step reference#6Copilot wants to merge 3 commits intosubmit_test-updatesfrom
Copilot wants to merge 3 commits intosubmit_test-updatesfrom
Conversation
Co-authored-by: softworkz <4985349+softworkz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update workflow execution in badgecount tests
Remove redundant workflow step with invalid step reference
Nov 14, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR removes a redundant workflow step that attempted to fail the workflow based on a non-existent step reference, addressing feedback from PR #5.
- Removed the "Fail if tests failed" step that referenced an undefined step ID
Publish_Test_Results
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
softworkz
force-pushed
the
submit_test-updates
branch
from
1866d5c to
825c240
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback on PR #5 regarding the "Fail if tests failed" step at line 102 which referenced a non-existent step ID.
Changes
steps.Publish_Test_Results.outcomeRationale
The step was unnecessary because:
dotnet testalready exits non-zero on test failurespublish-unit-test-result-actiondoesn't set failure outcomes—it only publishes results to the Checks UIPublish_Test_ResultsID was never defined)Test failures are caught naturally by the test execution steps (lines 68-84).
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.