Skip to content

Move ruby utils to module #4245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m-bert wants to merge 2 commits into
base: main
Choose a base branch
from
+24 −18
Open

Move ruby utils to module #4245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0977174
Make ruby functions local
m-bert Jun 8, 2026
0a18e5d
Add nil check
m-bert Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native-gesture-handler/RNGestureHandler.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ is_gh_example_app = ENV["GH_EXAMPLE_APP_NAME"] != nil

compilation_metadata_dir = "CompilationDatabase"
compilation_metadata_generation_flag = is_gh_example_app ? '-gen-cdb-fragment-path ' + compilation_metadata_dir : ''
version_flag = "-DREACT_NATIVE_MINOR_VERSION=#{rngh_get_react_native_minor_version()}"
version_flag = "-DREACT_NATIVE_MINOR_VERSION=#{GestureHandlerUtils.get_react_native_minor_version()}"

Pod::Spec.new do |s|
# NPM package specification
Expand Down
40 changes: 23 additions & 17 deletions packages/react-native-gesture-handler/scripts/gesture_handler_utils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,31 @@
def rngh_try_to_parse_react_native_package_json(react_native_dir)
react_native_package_json_path = File.join(react_native_dir, 'package.json')
module GestureHandlerUtils
module_function

if !File.exist?(react_native_package_json_path)
return nil
def try_to_parse_react_native_package_json(react_native_dir)
react_native_package_json_path = File.join(react_native_dir, 'package.json')

if !File.exist?(react_native_package_json_path)
return nil
end

return JSON.parse(File.read(react_native_package_json_path))
end

return JSON.parse(File.read(react_native_package_json_path))
end
def get_react_native_minor_version()
react_native_dir = File.dirname(`cd "#{Pod::Config.instance.installation_root.to_s}" && node --print "require.resolve('react-native/package.json')"`)
react_native_json = try_to_parse_react_native_package_json(react_native_dir)

def rngh_get_react_native_minor_version()
react_native_dir = File.dirname(`cd "#{Pod::Config.instance.installation_root.to_s}" && node --print "require.resolve('react-native/package.json')"`)
react_native_json = rngh_try_to_parse_react_native_package_json(react_native_dir)
if react_native_json == nil
node_modules_dir = ENV["REACT_NATIVE_NODE_MODULES_DIR"]
if node_modules_dir != nil
react_native_json = try_to_parse_react_native_package_json(File.join(node_modules_dir, 'react-native'))
end
end
Comment thread
m-bert marked this conversation as resolved.

if react_native_json == nil
node_modules_dir = ENV["REACT_NATIVE_NODE_MODULES_DIR"]
react_native_json = rngh_try_to_parse_react_native_package_json(File.join(node_modules_dir, 'react-native'))
end
if react_native_json == nil
raise '[react-native-gesture-handler] Unable to recognize your `react-native` version. Please set environmental variable with `react-native` location: `export REACT_NATIVE_NODE_MODULES_DIR="<path to react-native>" && pod install`.'
end

if react_native_json == nil
raise '[react-native-gesture-handler] Unable to recognize your `react-native` version. Please set environmental variable with `react-native` location: `export REACT_NATIVE_NODE_MODULES_DIR="<path to react-native>" && pod install`.'
return react_native_json['version'].split('.')[1].to_i
end

return react_native_json['version'].split('.')[1].to_i
end
Loading