[Android] Fix crash with RN Screens FormSheet#4243
Open
m-bert wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents an Android crash when React Native Screens’ DimmingView (and potentially other ReactCompoundView implementations) throws from reactTagForTouch, by safely handling that exception during gesture handler extraction.
Changes:
- Wraps
ReactCompoundView.reactTagForTouch(x, y)in atry/catchto avoid propagatingIllegalStateException. - Skips looking up handlers by the returned tag when the tag cannot be obtained (exception case), preventing the orchestrator from crashing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
j-piasecki
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DimmingViewfrom React Native Screens implementsReactCompoundViewGroup, which implementsReactCompoundView. However, this component is managed entirely by Screens, soreactTagForTouchthrows when called. This causes crash whenOrchestratortries to obtaintag(see here).To prevent that we add
try/catchblock. Note that simply checking forReactViewGroupwouldn't work, asTextis notReactViewGroup. There are also other components in Screens, which do not inherit fromReactViewGroup, but fromViewGroupinstead.Fixes #4237
Test plan
expo-example app (Nested Text and SVG)
The following code: