Skip to content

fix(pods): Fix invalid react-native/../react-native resolution for aliases #4232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kitten wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −7
Open

fix(pods): Fix invalid react-native/../react-native resolution for aliases #4232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e59e27
pods: Fix `react-native/../react-native` resolution failure
kitten Jun 3, 2026
274891c
Rename to be unique
kitten Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native-gesture-handler/RNGestureHandler.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ is_gh_example_app = ENV["GH_EXAMPLE_APP_NAME"] != nil

compilation_metadata_dir = "CompilationDatabase"
compilation_metadata_generation_flag = is_gh_example_app ? '-gen-cdb-fragment-path ' + compilation_metadata_dir : ''
version_flag = "-DREACT_NATIVE_MINOR_VERSION=#{get_react_native_minor_version()}"
version_flag = "-DREACT_NATIVE_MINOR_VERSION=#{rngh_get_react_native_minor_version()}"

Pod::Spec.new do |s|
# NPM package specification
Expand Down
12 changes: 6 additions & 6 deletions packages/react-native-gesture-handler/scripts/gesture_handler_utils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
def try_to_parse_react_native_package_json(node_modules_dir)
react_native_package_json_path = File.join(node_modules_dir, 'react-native/package.json')
def rngh_try_to_parse_react_native_package_json(react_native_dir)
react_native_package_json_path = File.join(react_native_dir, 'package.json')

if !File.exist?(react_native_package_json_path)
return nil
Expand All @@ -8,13 +8,13 @@ def try_to_parse_react_native_package_json(node_modules_dir)
return JSON.parse(File.read(react_native_package_json_path))
end

def get_react_native_minor_version()
react_native_node_modules_dir = File.join(File.dirname(`cd "#{Pod::Config.instance.installation_root.to_s}" && node --print "require.resolve('react-native/package.json')"`), '..')
react_native_json = try_to_parse_react_native_package_json(react_native_node_modules_dir)
def rngh_get_react_native_minor_version()
react_native_dir = File.dirname(`cd "#{Pod::Config.instance.installation_root.to_s}" && node --print "require.resolve('react-native/package.json')"`)
Comment thread
kitten marked this conversation as resolved.
react_native_json = rngh_try_to_parse_react_native_package_json(react_native_dir)

if react_native_json == nil
node_modules_dir = ENV["REACT_NATIVE_NODE_MODULES_DIR"]
react_native_json = try_to_parse_react_native_package_json(node_modules_dir)
react_native_json = rngh_try_to_parse_react_native_package_json(File.join(node_modules_dir, 'react-native'))
end

if react_native_json == nil
Expand Down