Skip to content

[Web] Fix wrong coordinate space #4209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m-bert wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Web] Fix wrong coordinate space #4209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions packages/react-native-gesture-handler/src/web/tools/GestureHandlerWebDelegate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,14 @@ export class GestureHandlerWebDelegate
throw new Error(tagMessage('Cannot convert coords on a null view'));
}

const rect = getEffectiveBoundingRect(this.view);
const transform = getComputedStyle(this.view).transform;
const localView =
this.gestureHandler.usesNativeOrVirtualDetector() &&
this.view.style.display === 'contents'
? (this.view.children[0] as HTMLElement)
: this.view;

const rect = getEffectiveBoundingRect(localView);
const transform = getComputedStyle(localView).transform;
const matrix =
transform && transform !== 'none'
? new DOMMatrix(transform)
Expand All @@ -164,8 +170,8 @@ export class GestureHandlerWebDelegate
const localOffset = inverse.transformPoint(new DOMPoint(dx, dy));

// Add back the local center (untransformed dimensions)
const localCenterX = this.view.offsetWidth / 2;
const localCenterY = this.view.offsetHeight / 2;
const localCenterX = localView.offsetWidth / 2;
const localCenterY = localView.offsetHeight / 2;

return {
x: localCenterX + localOffset.x,
Expand Down
Loading