Support React Native 0.86#4166
Draft
m-bert wants to merge 2 commits into
Draft
Conversation
m-bert
added
the
New React Native version support
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repo and example apps to support React Native 0.86 (rc), including dependency bumps and an iOS-native event dispatch change to avoid calling into non-callable JS modules on Fabric-only RN 0.86+.
Changes:
- Bump React Native (and related tooling) to
0.86.0-rc.0in the library dev setup andbasic-example. - Update iOS native animated event delivery to go through the event dispatcher’s observer pathway (instead of JS-facing direct events).
- Refresh lockfiles (Yarn + CocoaPods) for the upgraded dependency graph.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Large dependency graph update consistent with RN 0.86 rc + tooling bumps. |
| packages/react-native-gesture-handler/package.json | Updates devDependencies/testing presets and RN version used for development/testing. |
| packages/react-native-gesture-handler/apple/RNGestureHandlerManager.mm | Changes native animated event dispatch to use dispatcher observers (RN 0.86 Fabric-only compatibility). |
| apps/basic-example/package.json | Bumps basic-example to RN 0.86.0-rc.0 and aligned RN toolchain packages. |
| apps/basic-example/ios/Podfile.lock | Updates pods to match RN 0.86 rc and related native deps. |
| apps/basic-example/ios/BasicExample.xcodeproj/project.pbxproj | Adds build settings, including a problematic absolute PODFILE_DIR path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+476
to
+479
| // observer mechanism. We don't go through sendEvent: because that also | ||
| // dispatches the event to JS via RCTEventEmitter.receiveEvent, which is no | ||
| // longer a registered callable module in RN 0.86+ (Fabric-only). | ||
| [_eventDispatcher notifyObserversOfEvent:event]; |
| "$(inherited)", | ||
| " ", | ||
| ); | ||
| PODFILE_DIR = "/Users/michal/work/react-native-gesture-handler/apps/basic-example/ios"; |
| "$(inherited)", | ||
| " ", | ||
| ); | ||
| PODFILE_DIR = "/Users/michal/work/react-native-gesture-handler/apps/basic-example/ios"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR brings support for React Native 0.86
Required changes
RNRendererimport for React Native 0.86+ #4160Status
0.86.0-rc.0 ✅
Test plan
Tested that
basic-examplebuilds and works correctly.