Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Android borderless ripple animations being clipped by the button wrapper by avoiding overflow: hidden clipping when a button is configured as borderless. This aligns runtime behavior with the documented intent of borderless (“render outside the view bounds”).
Changes:
- Stop applying wrapper
overflow: 'hidden'styling whenborderlessis true. - Plumb
borderlessexplicitly into the nativeRNGestureHandlerButtoncomponent props.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Borderless ripple animation is currently broken due to being clipped by the wrapper view. This PR removes clipping for borderless buttons.
Test plan
Checked different variations of this