Skip to content

fix: oscillator producing silent on high frequencies #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdydek wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: oscillator producing silent on high frequencies #1083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions packages/react-native-audio-api/common/cpp/audioapi/core/effects/PeriodicWave.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,19 +192,17 @@ void PeriodicWave::createBandLimitedTables(
// We need to clear out the highest frequencies to band-limit the waveform.
auto numberOfPartials = getNumberOfPartialsPerRange(rangeIndex);

// Clamp the size to the number of partials.
auto clampedSize = std::min(size, numberOfPartials);

// copy real and imaginary data to the FFT frame, scale it and set the
// higher frequencies to zero.
// Copy frequency data into the FFT frame. Partial index 0 is DC; partial 1
// is the fundamental. Culling starts at partial (numberOfPartials + 1)
for (int i = 0; i < size; i++) {
if (i >= clampedSize && i < halfSize) {
complexFFTData[i] = std::complex<float>(0.0f, 0.0f);
} else {
complexFFTData[i] = {
complexData[i].real() * static_cast<float>(fftSize),
complexData[i].imag() * -static_cast<float>(fftSize)};
}
complexFFTData[i] = {
complexData[i].real() * static_cast<float>(fftSize),
complexData[i].imag() * -static_cast<float>(fftSize)};
}

const int cullFromIndex = std::min(size, numberOfPartials + 1);
for (int i = cullFromIndex; i < halfSize; i++) {
complexFFTData[i] = std::complex<float>(0.0f, 0.0f);
}

// Zero out the DC and nquist components.
Expand Down
Loading