Skip to content

feat: preloading in audio tag#1075

Merged
mdydek merged 6 commits into
mainfrom
feat/audio-tag-preload
May 27, 2026
Merged

feat: preloading in audio tag#1075
mdydek merged 6 commits into
mainfrom
feat/audio-tag-preload

Conversation

@mdydek
Copy link
Copy Markdown
Collaborator

@mdydek mdydek commented May 19, 2026

Closes #

⚠️ Breaking changes ⚠️

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web
  • Updated old arch android spec file

@mdydek mdydek added the feature New feature label May 19, 2026
Copy link
Copy Markdown
Contributor

@closetcaiman closetcaiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

I'm not a fan of the current state of Audio.tsx. Maybe we can consider refactoring it for readability in the future?

Comment thread packages/react-native-audio-api/src/development/react/Audio/Audio.tsx Outdated
Comment thread packages/react-native-audio-api/src/development/react/Audio/Audio.tsx Outdated
Comment thread packages/react-native-audio-api/src/utils/metadataPrefetching.ts
Comment thread packages/react-native-audio-api/src/development/react/Audio/utils.ts Outdated
Comment thread packages/react-native-audio-api/common/cpp/audioapi/libs/ffmpeg/FFmpegDecoding.h Outdated
@mdydek mdydek requested a review from closetcaiman May 20, 2026 13:49
Copy link
Copy Markdown
Contributor

@closetcaiman closetcaiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks. JD overall!

Comment thread packages/react-native-audio-api/common/cpp/audioapi/core/utils/AudioDecoding.cpp Outdated
Comment thread packages/react-native-audio-api/src/core/AudioFileUtils.ts
Comment thread packages/react-native-audio-api/src/development/react/Audio/utils.ts Outdated
Comment thread packages/react-native-audio-api/src/development/react/Audio/Audio.tsx Outdated
@mdydek mdydek requested a review from closetcaiman May 27, 2026 08:04
Co-authored-by: Cursor <cursoragent@cursor.com>
@mdydek mdydek merged commit a3deac7 into main May 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants