Open
Conversation
iwoplaza
requested review from
aleksanderkatan,
cieplypolar,
Copilot and
reczkok
|
pkg.pr.new packages benchmark commit |
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (346 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
There was a problem hiding this comment.
Pull request overview
This PR adjusts monorepo scripts to ensure generated “operator-overload stripped” example files are kept up-to-date (including .tsnotover.tsx) and to align dev usage with the current workspace (docs-only).
Changes:
- Update the root
dev/dev:hostscripts to run only thetypegpu-docsdev server. - Run
typegpu-docstransform-overloadsbefore executing workspace-widetest:types. - Expand the docs cleanup glob to delete both
.tsnotover.tsand.tsnotover.tsxgenerated files.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Limits dev to docs and ensures overload transforms run before type tests. |
| apps/typegpu-docs/package.json | Broadens cleanup of generated .tsnotover files to include TSX variants. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "type": "module", | ||
| "scripts": { | ||
| "transform-overloads": "find . -type f -name '*.tsnotover.ts' -delete && node scripts/transform-overloads.ts", | ||
| "transform-overloads": "find . -type f -name '*.tsnotover.ts*' -delete && node scripts/transform-overloads.ts", |
There was a problem hiding this comment.
The find . ... -delete cleanup runs over the entire package (including node_modules), which can be slow and also broader than necessary. Since scripts/transform-overloads.ts only reads/writes under src/examples, consider scoping the delete to that directory and matching only the intended extensions (e.g., separate *.tsnotover.ts and *.tsnotover.tsx patterns) to avoid deleting unintended files.
Suggested change
| "transform-overloads": "find . -type f -name '*.tsnotover.ts*' -delete && node scripts/transform-overloads.ts", | |
| "transform-overloads": "find ./src/examples -type f \\( -name '*.tsnotover.ts' -o -name '*.tsnotover.tsx' \\) -delete && node scripts/transform-overloads.ts", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.tsnotover.tsxas well as.tsnotover.tsfiles, preparing for the upcoming @typegpu/react package.devscript on the docs only, as no other packages have adevcommand (they used to)