chore: Sort treeshake-test results by impact in GitHub comments#2268
Open
chore: Sort treeshake-test results by impact in GitHub comments#2268
Conversation
|
pkg.pr.new packages benchmark commit |
iwoplaza
changed the title
iwoplaza
force-pushed
the
chore/treeshake-results-sort
branch
2 times, most recently
from
21c1434 to
27a4fa5
Compare
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (344 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
iwoplaza
force-pushed
the
chore/treeshake-results-sort
branch
2 times, most recently
from
d8d4e47 to
b8606e9
Compare
iwoplaza
requested review from
aleksanderkatan,
cieplypolar,
Copilot and
reczkok
There was a problem hiding this comment.
Pull request overview
This PR improves the readability of the treeshake-test GitHub comment output by ordering results so that the most impactful bundle size changes are shown first.
Changes:
- Sort results rows by maximum absolute relative size change across all bundlers (descending).
- Add a helper (
#maxAbsoluteChange) to compute the per-row “impact” used for sorting.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+53
to
+55
| const sortedResults = [...this.#results.entries()].toSorted( | ||
| ([, a], [, b]) => this.#maxAbsoluteChange(b) - this.#maxAbsoluteChange(a), | ||
| ); |
There was a problem hiding this comment.
The sort comparator recomputes #maxAbsoluteChange(...) for the same rows many times during sorting. Consider precomputing the max-change score once per row (decorate entries with the score, sort by it, then strip) to keep the sort O(n log n) without the repeated per-comparison scans over row.values().
Suggested change
| const sortedResults = [...this.#results.entries()].toSorted( | |
| ([, a], [, b]) => this.#maxAbsoluteChange(b) - this.#maxAbsoluteChange(a), | |
| ); | |
| const sortedResults = [...this.#results.entries()] | |
| .map(([test, row]) => [test, row, this.#maxAbsoluteChange(row)] as const) | |
| .toSorted(([, , scoreA], [, , scoreB]) => scoreB - scoreA) | |
| .map(([test, row]) => [test, row] as const); |
iwoplaza
force-pushed
the
chore/treeshake-results-sort
branch
from
b8606e9 to
8e62f2b
Compare
iwoplaza
force-pushed
the
chore/treeshake-results-sort
branch
from
8e62f2b to
840a244
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.